-
Notifications
You must be signed in to change notification settings - Fork 3
chore: remove unused query parameter from surveys package call #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA fixed query parameter was removed from the URL used to load an external JavaScript survey library in the Android WebView integration. The script source is now a direct path without any appended query string. No changes were made to public interfaces or exported entities. Changes
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
android/src/main/java/com/formbricks/android/webview/FormbricksViewModel.kt (1)
101-103: Removed unusedrandQueryquery parameterCleaning up the hard-coded
?randQuery=123445simplifies the script URL. Before merging, verify that you have an alternative cache-busting or versioning strategy (e.g., versioned URLs or cache headers) to ensure clients load updated survey scripts when they change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
android/src/main/java/com/formbricks/android/webview/FormbricksViewModel.kt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: SonarCloud
- GitHub Check: Analyze (java-kotlin)
|



This pull request includes a minor update to the
FormbricksViewModelclass in theFormbricksAndroid project. The change removes a hardcoded query parameter from the URL used to load the survey script.android/src/main/java/com/formbricks/android/webview/FormbricksViewModel.kt: Removed therandQuery=123445query parameter from thescript.srcURL to simplify the script loading process.Summary by CodeRabbit