Skip to content

Conversation

@pandeymangg
Copy link
Contributor

@pandeymangg pandeymangg commented May 26, 2025

This pull request updates dependencies and plugins in the Android project to ensure compatibility and improve maintainability. Key changes include upgrading the Dokka plugin, updating various library versions, and removing unused dependencies.

Plugin Updates:

  • Updated org.jetbrains.dokka plugin to version 1.9.20 in android/build.gradle.kts.

Dependency Updates:

  • Removed the unused androidx.legacy.support.v4 dependency from android/build.gradle.kts.
  • Updated versions of several dependencies in gradle/libs.versions.toml:
    • Upgraded retrofit to 3.0.0.
    • Upgraded okhttp3 to 4.12.0.
    • Upgraded gson to 2.13.1.
    • Updated lifecycle-livedata-ktx to 2.9.0 and lifecycle-viewmodel-ktx to 2.9.0.
    • Updated fragment-ktx to 1.8.7.

Dependency Cleanup:

  • Removed the androidx-legacy-support-v4 entry from gradle/libs.versions.toml as it is no longer used.

With the removal of the androidx-legacy-support-v4 dependency, the SDK no longer relies on deprecated android.support.* libraries. This change does not reduce device compatibility for consuming apps.

The minimum supported Android version remains API 21 (Android 5.0, Lollipop), which is fully compatible with AndroidX at runtime. Consumers of the SDK can still configure minSdkVersion = 21 in their apps without any issues.

Summary by CodeRabbit

  • Chores
    • Updated several library dependencies to their latest versions, including Retrofit, OkHttp, Gson, and AndroidX Lifecycle components.
    • Upgraded the documentation plugin to a newer version.
    • Removed the legacy Android support library from the project.

@pandeymangg pandeymangg requested review from Copilot and mattinannt and removed request for mattinannt May 26, 2025 10:20
@coderabbitai
Copy link

coderabbitai bot commented May 26, 2025

Walkthrough

The changes update several dependency versions in the Gradle configuration files, including Retrofit, OkHttp, Gson, and AndroidX lifecycle libraries. The Dokka plugin version is incremented, and the AndroidX legacy support v4 library is removed from both the build script and dependency definitions. No changes affect public API signatures.

Changes

Files Change Summary
android/build.gradle.kts Updated Dokka plugin version; removed JaCoCo comment and legacy support v4 dependency.
gradle/libs.versions.toml Updated versions for Retrofit, OkHttp, Gson, lifecycle, and fragment libraries; removed legacy support v4 entry.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependency and plugin versions in the Android project to improve compatibility and maintainability. Key changes include:

  • Upgrading the Dokka plugin in the Android build script
  • Updating dependency versions in the TOML file
  • Removing the unused legacy support dependency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
gradle/libs.versions.toml Updated dependency versions and removed unused legacy entry
android/build.gradle.kts Upgraded the Dokka plugin version and removed legacy support code

@pandeymangg pandeymangg requested a review from mattinannt May 26, 2025 10:20
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23610fa and ad51e45.

📒 Files selected for processing (2)
  • android/build.gradle.kts (1 hunks)
  • gradle/libs.versions.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: SonarCloud
  • GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
android/build.gradle.kts (1)

8-8:

❓ Verification inconclusive

Verify Dokka plugin compatibility
Confirm that upgrading to org.jetbrains.dokka version 1.9.20 is compatible with Kotlin 2.1.0 and your Gradle setup. Ensure any custom Dokka tasks or configurations (e.g., dokkaHtml) are updated to work with the new version.

Run the following script to locate Dokka references and task configurations:


🏁 Script executed:

#!/bin/bash
# Search for Dokka plugin and tasks in Gradle files
rg -Hn 'dokka' --include '*.gradle*'

Length of output: 478


🏁 Script executed:

#!/bin/bash
# Re-run search for Dokka references in Gradle files with correct flags

# Using ripgrep with --glob
rg -Hn 'dokka' -g '*.gradle*'

# Fallback to grep if ripgrep isn't matching
grep -R 'dokka' --include='*.gradle*' -n .

Length of output: 222


Verify Dokka 1.9.20 compatibility with Kotlin 2.1.0
We only found the single declaration below and no other Dokka tasks or configurations in your Gradle files. Please confirm that org.jetbrains.dokka:1.9.20 is fully compatible with Kotlin 2.1.0 and your Gradle version, and update any custom Dokka tasks (e.g., dokkaHtml) if you add them later.

• android/build.gradle.kts (line 8):

id("org.jetbrains.dokka") version "1.9.20"

@sonarqubecloud
Copy link

@pandeymangg pandeymangg added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit 873799d May 27, 2025
7 checks passed
mattinannt added a commit that referenced this pull request Jun 2, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

---------

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Co-authored-by: Matti Nannt <mail@matti.sh>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 5, 2025
…bile-SDK-Custom) (#26)

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

---------

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Co-authored-by: Matti Nannt <mail@matti.sh>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 10, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

---------

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Co-authored-by: Matti Nannt <mail@matti.sh>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 12, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

---------

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Co-authored-by: Matti Nannt <mail@matti.sh>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 13, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

* fix show survey when app is not resumed

---------

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Co-authored-by: Matti Nannt <mail@matti.sh>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 16, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

* fix show survey when app is not resumed

* fix safeDismiss

* fix launchWhenResumed

---------

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Co-authored-by: Matti Nannt <mail@matti.sh>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 17, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

* fix show survey when app is not resumed

* fix safeDismiss

* fix launchWhenResumed

* add try catch cancel call api

---------

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Co-authored-by: Matti Nannt <mail@matti.sh>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mattinannt added a commit that referenced this pull request Jun 27, 2025
* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* chore: custom sdk tcb

* fix: blackduck issues (#22)

* fixes blackduck issues

* fix: dokka version

* fix: Workflow does not contain permissions (#20)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* chore: handle back press survey

* chore: handle back press survey

* fix: fixes the pixel fold issue (#24)

* fixes the pixel fold issue

* adds errors

* fixes log

* add hidden field

* handle back press survey

* fixes responses stuck error (#25)

* feat(api): add cancel support for ongoing retrofit calls

* fix: blocks http requests (#27)

* fix: blocks http requests

* fix: fixes network sec config

* fix: retrofit

* feat(network): enforce TLS 1.2 1.3 support odder Android version

* fix: branding text (#30)

* fix: branding text

* fix: test

* chore: update isBrandingEnabled

* fix show survey when app is not resumed

* fix safeDismiss

* fix launchWhenResumed

* add try catch cancel call api

* fix(android): adjust WebView height manually on Android 10 when keyboard is visible

---------

Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com>
Co-authored-by: Matti Nannt <mail@matti.sh>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants