-
Notifications
You must be signed in to change notification settings - Fork 3
fix: blackduck issues #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update several dependency versions in the Gradle configuration files, including Retrofit, OkHttp, Gson, and AndroidX lifecycle libraries. The Dokka plugin version is incremented, and the AndroidX legacy support v4 library is removed from both the build script and dependency definitions. No changes affect public API signatures. Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependency and plugin versions in the Android project to improve compatibility and maintainability. Key changes include:
- Upgrading the Dokka plugin in the Android build script
- Updating dependency versions in the TOML file
- Removing the unused legacy support dependency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updated dependency versions and removed unused legacy entry |
| android/build.gradle.kts | Upgraded the Dokka plugin version and removed legacy support code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
android/build.gradle.kts(1 hunks)gradle/libs.versions.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: SonarCloud
- GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (1)
android/build.gradle.kts (1)
8-8:❓ Verification inconclusive
Verify Dokka plugin compatibility
Confirm that upgrading toorg.jetbrains.dokkaversion1.9.20is compatible with Kotlin2.1.0and your Gradle setup. Ensure any custom Dokka tasks or configurations (e.g.,dokkaHtml) are updated to work with the new version.Run the following script to locate Dokka references and task configurations:
🏁 Script executed:
#!/bin/bash # Search for Dokka plugin and tasks in Gradle files rg -Hn 'dokka' --include '*.gradle*'Length of output: 478
🏁 Script executed:
#!/bin/bash # Re-run search for Dokka references in Gradle files with correct flags # Using ripgrep with --glob rg -Hn 'dokka' -g '*.gradle*' # Fallback to grep if ripgrep isn't matching grep -R 'dokka' --include='*.gradle*' -n .Length of output: 222
Verify Dokka 1.9.20 compatibility with Kotlin 2.1.0
We only found the single declaration below and no other Dokka tasks or configurations in your Gradle files. Please confirm thatorg.jetbrains.dokka:1.9.20is fully compatible with Kotlin 2.1.0 and your Gradle version, and update any custom Dokka tasks (e.g.,dokkaHtml) if you add them later.• android/build.gradle.kts (line 8):
id("org.jetbrains.dokka") version "1.9.20"
|
* chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * fix: blackduck issues (#22) * fixes blackduck issues * fix: dokka version * fix: Workflow does not contain permissions (#20) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: handle back press survey * chore: handle back press survey --------- Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Co-authored-by: Matti Nannt <mail@matti.sh> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…bile-SDK-Custom) (#26) * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * fix: blackduck issues (#22) * fixes blackduck issues * fix: dokka version * fix: Workflow does not contain permissions (#20) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: handle back press survey * chore: handle back press survey * fix: fixes the pixel fold issue (#24) * fixes the pixel fold issue * adds errors * fixes log * add hidden field * handle back press survey * fixes responses stuck error (#25) * feat(api): add cancel support for ongoing retrofit calls --------- Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Co-authored-by: Matti Nannt <mail@matti.sh> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * fix: blackduck issues (#22) * fixes blackduck issues * fix: dokka version * fix: Workflow does not contain permissions (#20) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: handle back press survey * chore: handle back press survey * fix: fixes the pixel fold issue (#24) * fixes the pixel fold issue * adds errors * fixes log * add hidden field * handle back press survey * fixes responses stuck error (#25) * feat(api): add cancel support for ongoing retrofit calls * fix: blocks http requests (#27) * fix: blocks http requests * fix: fixes network sec config * fix: retrofit * feat(network): enforce TLS 1.2 1.3 support odder Android version --------- Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Co-authored-by: Matti Nannt <mail@matti.sh> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * fix: blackduck issues (#22) * fixes blackduck issues * fix: dokka version * fix: Workflow does not contain permissions (#20) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: handle back press survey * chore: handle back press survey * fix: fixes the pixel fold issue (#24) * fixes the pixel fold issue * adds errors * fixes log * add hidden field * handle back press survey * fixes responses stuck error (#25) * feat(api): add cancel support for ongoing retrofit calls * fix: blocks http requests (#27) * fix: blocks http requests * fix: fixes network sec config * fix: retrofit * feat(network): enforce TLS 1.2 1.3 support odder Android version * fix: branding text (#30) * fix: branding text * fix: test * chore: update isBrandingEnabled --------- Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Co-authored-by: Matti Nannt <mail@matti.sh> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * fix: blackduck issues (#22) * fixes blackduck issues * fix: dokka version * fix: Workflow does not contain permissions (#20) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: handle back press survey * chore: handle back press survey * fix: fixes the pixel fold issue (#24) * fixes the pixel fold issue * adds errors * fixes log * add hidden field * handle back press survey * fixes responses stuck error (#25) * feat(api): add cancel support for ongoing retrofit calls * fix: blocks http requests (#27) * fix: blocks http requests * fix: fixes network sec config * fix: retrofit * feat(network): enforce TLS 1.2 1.3 support odder Android version * fix: branding text (#30) * fix: branding text * fix: test * chore: update isBrandingEnabled * fix show survey when app is not resumed --------- Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Co-authored-by: Matti Nannt <mail@matti.sh> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * fix: blackduck issues (#22) * fixes blackduck issues * fix: dokka version * fix: Workflow does not contain permissions (#20) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: handle back press survey * chore: handle back press survey * fix: fixes the pixel fold issue (#24) * fixes the pixel fold issue * adds errors * fixes log * add hidden field * handle back press survey * fixes responses stuck error (#25) * feat(api): add cancel support for ongoing retrofit calls * fix: blocks http requests (#27) * fix: blocks http requests * fix: fixes network sec config * fix: retrofit * feat(network): enforce TLS 1.2 1.3 support odder Android version * fix: branding text (#30) * fix: branding text * fix: test * chore: update isBrandingEnabled * fix show survey when app is not resumed * fix safeDismiss * fix launchWhenResumed --------- Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Co-authored-by: Matti Nannt <mail@matti.sh> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * fix: blackduck issues (#22) * fixes blackduck issues * fix: dokka version * fix: Workflow does not contain permissions (#20) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: handle back press survey * chore: handle back press survey * fix: fixes the pixel fold issue (#24) * fixes the pixel fold issue * adds errors * fixes log * add hidden field * handle back press survey * fixes responses stuck error (#25) * feat(api): add cancel support for ongoing retrofit calls * fix: blocks http requests (#27) * fix: blocks http requests * fix: fixes network sec config * fix: retrofit * feat(network): enforce TLS 1.2 1.3 support odder Android version * fix: branding text (#30) * fix: branding text * fix: test * chore: update isBrandingEnabled * fix show survey when app is not resumed * fix safeDismiss * fix launchWhenResumed * add try catch cancel call api --------- Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Co-authored-by: Matti Nannt <mail@matti.sh> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * chore: custom sdk tcb * fix: blackduck issues (#22) * fixes blackduck issues * fix: dokka version * fix: Workflow does not contain permissions (#20) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * chore: handle back press survey * chore: handle back press survey * fix: fixes the pixel fold issue (#24) * fixes the pixel fold issue * adds errors * fixes log * add hidden field * handle back press survey * fixes responses stuck error (#25) * feat(api): add cancel support for ongoing retrofit calls * fix: blocks http requests (#27) * fix: blocks http requests * fix: fixes network sec config * fix: retrofit * feat(network): enforce TLS 1.2 1.3 support odder Android version * fix: branding text (#30) * fix: branding text * fix: test * chore: update isBrandingEnabled * fix show survey when app is not resumed * fix safeDismiss * fix launchWhenResumed * add try catch cancel call api * fix(android): adjust WebView height manually on Android 10 when keyboard is visible --------- Co-authored-by: Anshuman Pandey <54475686+pandeymangg@users.noreply.github.com> Co-authored-by: Matti Nannt <mail@matti.sh> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>



This pull request updates dependencies and plugins in the Android project to ensure compatibility and improve maintainability. Key changes include upgrading the Dokka plugin, updating various library versions, and removing unused dependencies.
Plugin Updates:
org.jetbrains.dokkaplugin to version1.9.20inandroid/build.gradle.kts.Dependency Updates:
androidx.legacy.support.v4dependency fromandroid/build.gradle.kts.gradle/libs.versions.toml:retrofitto3.0.0.okhttp3to4.12.0.gsonto2.13.1.lifecycle-livedata-ktxto2.9.0andlifecycle-viewmodel-ktxto2.9.0.fragment-ktxto1.8.7.Dependency Cleanup:
androidx-legacy-support-v4entry fromgradle/libs.versions.tomlas it is no longer used.With the removal of the
androidx-legacy-support-v4dependency, the SDK no longer relies on deprecatedandroid.support.*libraries. This change does not reduce device compatibility for consuming apps.The minimum supported Android version remains API 21 (Android 5.0, Lollipop), which is fully compatible with AndroidX at runtime. Consumers of the SDK can still configure minSdkVersion = 21 in their apps without any issues.
Summary by CodeRabbit