CAN fix for VDM #29
Merged
CAN fix for VDM #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholas-tangerine
force-pushed
the
can_fix
branch
from
dbfaaf1 to
d3b15ae
Compare
MatinQurban
approved these changes
Nov 13, 2025
Contributor
MatinQurban
left a comment
MatinQurban
left a comment
There was a problem hiding this comment.
Nicholas created LapCounter class to replace updateLapTime and related functions in VehicleState class.
This new class holds a LapCounterData struct that holds the position of the start-finish line, current position of the vehicle, and last read position of the car. As well as a timer and lap counter.
This class has functions to reset lap counter and gps data, updates lap counter if certain criteria are met, and read the timer.
Also added the new class to cmake executable list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see most recent commit message
please only merge after lap count to minimize merge conflict