support .fpp suffix for fypp files #1031
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 12 12
Lines 2312 2312
Branches 205 205
=======================================
Hits 1933 1933
Misses 374 374
Partials 5 5 ☔ View full report in Codecov by Sentry. |
gnikit
requested changes
Dec 30, 2023
Member
gnikit
left a comment
gnikit
left a comment
There was a problem hiding this comment.
I don't really understand this PR or the problem it tries to fix. The extensions are already registered. The change in the test folder only affects the tests not the actual extension. I will be closing this PR due to duplication.
Comment on lines
+92
to
+93
| ".fpp", | ||
| ".FPP", |
Member
There was a problem hiding this comment.
This is already present in lines 88-89
Author
|
My mistake, had brief trouble with syntax recognition on an fpp file and did this with no due diligence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fypp docs seem to use
.fppand.fyppinterchangeably