Skip to content

Conversation

@coreylafferty
Copy link
Member

No description provided.

@coreylafferty coreylafferty requested a review from kmonahan July 14, 2023 15:36
Copy link
Collaborator

@kmonahan kmonahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coreylafferty Looks like the spacing.css file itself is missing from the PR

Base automatically changed from 1.x-RC to 1.x July 19, 2023 12:54
@kmonahan
Copy link
Collaborator

Tested both with local node and with ddev and both by running npm run lint manually and by making a commit. In all cases, I wasn't able to replicate the issue that @coreylafferty was seeing locally, where type-checking was failing due to a weird error deep within node_modules. @mdrayer , can you test this branch locally as well and see if you spot anything odd?

@coreylafferty
Copy link
Member Author

@kmonahan I fixed my issue locally. Just needed to use the proper node version. I think this can be merged if it looks good to you.

@kmonahan kmonahan changed the base branch from 1.x to 1.x-RC July 26, 2023 13:40
@kmonahan kmonahan merged commit 6541f1a into 1.x-RC Jul 26, 2023
@kmonahan kmonahan deleted the spacing-utility branch July 26, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants