added linkclasses to menu story #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmonahan
reviewed
Jul 26, 2023
| ...footerMenuArgs, | ||
| modifierClasses: footerStyles.menu, | ||
| itemClasses: footerStyles.item, | ||
| linkClasses: footerStyles.link, |
Collaborator
There was a problem hiding this comment.
Hmm, I think the reason this wasn't included initially is because there is no .link class in menu-footer.module.css. If we want to include this here as an example, maybe we should also add some link styling rule, because otherwise, I think omitting the linkClasses arg if it's not needed is correct. Thoughts?
Member
Author
There was a problem hiding this comment.
I added a .link placeholder to the menu and menu-footer CSS. Will that work?
kmonahan
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.