Skip to content

Conversation

@hongquan
Copy link
Member

@hongquan hongquan commented Oct 28, 2025

Resolves #1128

Result:

image

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @hongquan, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@hongquan hongquan requested a review from Copilot October 28, 2025 05:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a NoReverseMatch error by updating URL namespace references from control: to eventyay_common: for authentication and OAuth2-related URLs. The changes ensure proper URL resolution throughout the application.

  • Updated URL namespaces from control:auth.login, control:auth.register, and control:oauth2_provider.authorize to their eventyay_common: equivalents
  • Standardized translation template tags from {% trans %} to {% translate %}
  • Minor code cleanup including import reordering and comment formatting

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
app/eventyay/presale/templates/pretixpresale/fragment_modals.html Updated authentication URL namespaces and standardized translation tags
app/eventyay/plugins/socialauth/views.py Fixed OAuth2 and login URL namespaces, improved comment formatting
app/eventyay/eventyay_common/views/account/basic.py Updated login URL namespace and reorganized imports
app/eventyay/base/templatetags/login_url.py Fixed login URL namespace in template tag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mariobehling mariobehling merged commit b93d807 into fossasia:enext Oct 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NoReverseMatch error when accessing ticket sale page as attendee

2 participants