Skip to content

fix: resolve PDF download issues #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: enext
Choose a base branch
from
Open

fix: resolve PDF download issues #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6fa1860
fix: resolve PDF download issues #1245 #1247
ArnavBallinCode Nov 13, 2025
59dd731
fix: correct extra closing brace in filename format string
ArnavBallinCode Nov 13, 2025
abaa584
Merge branch 'enext' into fix/pdf-download-issues-1245-1247
mariobehling Nov 13, 2025
27d9c14
Merge branch 'enext' into fix/pdf-download-issues-1245-1247
ArnavBallinCode Nov 14, 2025
cd3a62b
Merge branch 'enext' into fix/pdf-download-issues-1245-1247
ArnavBallinCode Nov 14, 2025
accfbf6
Merge branch 'enext' into fix/pdf-download-issues-1245-1247
ArnavBallinCode Nov 17, 2025
ce210c7
Merge branch 'enext' into fix/pdf-download-issues-1245-1247
ArnavBallinCode Nov 19, 2025
eb0bfc2
Merge branch 'enext' into fix/pdf-download-issues-1245-1247
mariobehling Nov 20, 2025
7b564f2
Merge branch 'enext' into fix/pdf-download-issues-1245-1247
ArnavBallinCode Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app/eventyay/api/views/order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,9 @@ def download(self, request, output, **kwargs):
return resp
else:
resp = FileResponse(ct.file.file, content_type=ct.type)
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
resp['Content-Disposition'] = 'attachment; filename="{}-{}{}"'.format(
self.request.event.slug.upper(),
order.code,
provider.identifier,
ct.extension,
)
return resp
Expand Down Expand Up @@ -1094,11 +1093,10 @@ def download(self, request, output, **kwargs):
return resp
else:
resp = FileResponse(ct.file.file, content_type=ct.type)
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
self.request.event.slug.upper(),
pos.order.code,
pos.positionid,
provider.identifier,
ct.extension,
)
return resp
Expand Down
6 changes: 2 additions & 4 deletions app/eventyay/control/views/orders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,20 +510,18 @@ def success(self, value):
return resp
else:
resp = FileResponse(value.file.file, content_type=value.type)
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
self.request.event.slug.upper(),
self.order.code,
self.order_position.positionid,
self.output.identifier,
value.extension,
)
return resp
elif isinstance(value, CachedCombinedTicket):
resp = FileResponse(value.file.file, content_type=value.type)
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
resp['Content-Disposition'] = 'attachment; filename="{}-{}{}"'.format(
self.request.event.slug.upper(),
self.order.code,
self.output.identifier,
value.extension,
)
return resp
Expand Down
23 changes: 15 additions & 8 deletions app/eventyay/presale/views/order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,31 +1085,38 @@ def success(self, value):
return resp
else:
resp = FileResponse(value.file.file, content_type=value.type)
if self.order_position.subevent:
if self.order_position and self.order_position.subevent:
# Subevent date in filename improves accessibility e.g. for screen reader users
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}-{}{}"'.format(
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(
self.request.event.slug.upper(),
self.order.code,
self.order_position.positionid,
self.order_position.subevent.date_from.strftime('%Y_%m_%d'),
self.output.identifier,
value.extension,
)
else:
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(
elif self.order_position:
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
self.request.event.slug.upper(),
self.order.code,
self.order_position.positionid,
self.output.identifier,
value.extension,
)
else:
# Fallback if order_position is not available
resp['Content-Disposition'] = (
'attachment; filename="{}-{}{}"'.format(
self.request.event.slug.upper(),
self.order.code,
value.extension,
)
)
return resp
return resp
elif isinstance(value, CachedCombinedTicket):
resp = FileResponse(value.file.file, content_type=value.type)
resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
resp['Content-Disposition'] = 'attachment; filename="{}-{}{}"'.format(
self.request.event.slug.upper(),
self.order.code,
self.output.identifier,
value.extension,
)
return resp
Expand Down