-
Notifications
You must be signed in to change notification settings - Fork 122
Dropdown menu on tickets sale page is now visible #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown menu on tickets sale page is now visible #806
Conversation
Reviewer's GuideThis PR makes the dropdown menu on the ticket sale page always visible by removing the conditional guard around the login status fragment and standardizes translation tags from 'trans' to 'translate'. Class diagram for login status fragment template changesclassDiagram
class LoginStatusFragment {
- organizer_name
- event_slug
- show_organizer_area
- popover_toggle
- base_path
+ login dropdown always visible
+ uses 'translate' tag
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Gagan-Ram - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/pretix/presale/templates/pretixpresale/fragment_login_status.html:5` </location>
<code_context>
-{% if request.organizer.settings.customer_accounts %}
</code_context>
<issue_to_address>
Removing the customer_accounts check may expose login UI in unintended contexts.
Without this check, the login UI will appear even when customer accounts are disabled, which may confuse users or display non-functional elements. Please confirm if this is intentional or if the UI should remain hidden in such cases.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This PR is implemented by bypassing this check: if request.organizer.settings.customer_accountsI don't know what what this setting is for. Let's merge this PR and revisit this setting later. |
Fixes: #805
Summary by Sourcery
Ensure the account dropdown in the header is always rendered on the ticket sale page by removing the customer_accounts feature guard and standardize translation tags.
Bug Fixes:
Enhancements: