feat: save location name in a shared preference #172
Conversation
| private val eventsViewModel by viewModel<EventsViewModel>() | ||
| private lateinit var rootView: View | ||
| private val preference: Preference = Preference() | ||
| private val tokenKey = "LOCATION" |
There was a problem hiding this comment.
There's a reason to use MVVM. Please don't add logic in Views
|
@iamareebjamal moved entire preference logic to ViewModel. |
| private val eventsRecyclerAdapter: EventsRecyclerAdapter = EventsRecyclerAdapter() | ||
| private val eventsViewModel by viewModel<EventsViewModel>() | ||
| private lateinit var rootView: View | ||
| private val preference: Preference = Preference() |
There was a problem hiding this comment.
@iamareebjamal I moved the logic to viewmodel in this commit 0636e28
but the tests were failing so I reverted.
Was it the correct way?
|
@iamareebjamal I tried to fix the failing dependency test but I wasn't able Could you please help |
| val error = MutableLiveData<String>() | ||
|
|
||
| var locationName: String? = null | ||
| var locationName: String? = preference.getString(tokenKey) |
There was a problem hiding this comment.
Make this lazy, it'll work
| var locationName: String? = null | ||
| var locationName: String? = preference.getString(tokenKey) | ||
|
|
||
| fun loadLocationEvents() { |
There was a problem hiding this comment.
Why not take the location name as parameter
|
@iamareebjamal Did all the requested changes please review |
| class EventsViewModel(private val eventService: EventService, private val preference: Preference) : ViewModel() { | ||
|
|
||
| private val compositeDisposable = CompositeDisposable() | ||
| val tokenKey = "LOCATION" |
|
PR updated, please review |
2 participants
fixes #159
Now events can be loaded automatically when the user opens the app