NullPointerException on thumbnail parsing

[iamareebjamal]

Actual Behaviour

Some speaker thumbnails are null and thus cause NPE

Expected Behaviour

Null checks should be added in Speaker Adapter and Session Speaker Adapter

Steps to reproduce it

Go to Speaker Fragment and sort by organisation and search 'Ho'
App will crash

LogCat for the issue

E/AndroidRuntime: FATAL EXCEPTION: main
                                                                      Process: org.fossasia.openevent, PID: 6912
                                                                      java.lang.NullPointerException: uriString
                                                                          at android.net.Uri$StringUri.<init>(Uri.java:475)
                                                                          at android.net.Uri$StringUri.<init>(Uri.java)
                                                                          at android.net.Uri.parse(Uri.java:437)
                                                                          at org.fossasia.openevent.adapters.SpeakersListAdapter.onBindViewHolder(SpeakersListAdapter.java:99)
                                                                          at org.fossasia.openevent.adapters.SpeakersListAdapter.onBindViewHolder(SpeakersListAdapter.java:36)
                                                                          at android.support.v7.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:6356)
                                                                          at android.support.v7.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:6389)
                                                                          at android.support.v7.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:5335)
                                                                          at android.support.v7.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:5598)
                                                                          at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:5440)
                                                                          at android.support.v7.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:5436)
                                                                          at android.support.v7.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2224)
                                                                          at android.support.v7.widget.GridLayoutManager.layoutChunk(GridLayoutManager.java:556)
                                                                          at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1511)
                                                                          at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:595)
                                                                          at android.support.v7.widget.GridLayoutManager.onLayoutChildren(GridLayoutManager.java:170)
                                                                          at android.support.v7.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:3583)
                                                                          at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3312)
                                                                          at android.support.v7.widget.RecyclerView.consumePendingUpdateOperations(RecyclerView.java:1648)
                                                                          at android.support.v7.widget.RecyclerView$1.run(RecyclerView.java:343)
                                                                          at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874)
                                                                          at android.view.Choreographer.doCallbacks(Choreographer.java:686)
                                                                          at android.view.Choreographer.doFrame(Choreographer.java:618)
                                                                          at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860)
                                                                          at android.os.Handler.handleCallback(Handler.java:751)
                                                                          at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                          at android.os.Looper.loop(Looper.java:154)
                                                                          at android.app.ActivityThread.main(ActivityThread.java:6169)
                                                                          at java.lang.reflect.Method.invoke(Native Method)
                                                                          at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:888)
                                                                          at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:778)

Would you like to work on the issue?

Yes. Sending PR

[mananwason]

Please edit the issue to cover all such occurrences and solve all of them in one PR

[iamareebjamal]

@mananwason Done