fix admin sales #1929
Merged
fix admin sales #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavk96
approved these changes
Jan 21, 2019
Contributor
abhinavk96
left a comment
abhinavk96
left a comment
There was a problem hiding this comment.
Excellent work @YogeshSharma0201 , will merge this after the server PR is merged.
YogeshSharma0201
force-pushed
the
fix_admin_sales
branch
from
b1faa44 to
e556977
Compare
abhinavk96
suggested changes
Jan 21, 2019
abhinavk96
suggested changes
Jan 21, 2019
Contributor
abhinavk96
left a comment
abhinavk96
left a comment
There was a problem hiding this comment.
Please do these changes for all the model hooks @YogeshSharma0201
| pendingSales : 0.00 | ||
| }, | ||
| async model() { | ||
| let filterOptions = []; |
Contributor
There was a problem hiding this comment.
you can get rid of filterOptions completely.
| pendingSales : 36.00 | ||
| } | ||
| ]; | ||
| return this.store.query('admin-sales-discounted', { |
Contributor
There was a problem hiding this comment.
use this.store.findAll()
Contributor
Author
There was a problem hiding this comment.
@CosmicCoder96 i have made the changes.
Member
|
@YogeshSharma0201 great work 🎉 |
YogeshSharma0201
force-pushed
the
fix_admin_sales
branch
from
e556977 to
fa1d69d
Compare
YogeshSharma0201
force-pushed
the
fix_admin_sales
branch
from
fa1d69d to
b0c1315
Compare
abhinavk96
approved these changes
Jan 23, 2019
This was referenced Jan 24, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires backend changes (fossasia/open-event-server/pull/5528) to be merged first.
Checklist
developmentbranch.Short description of what this resolves:
Fixes #1807