feat: allow deletion of team members #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

iamareebjamal merged 6 commits into fossasia:development from sachinchauhan2889:roles

Jan 16, 2021

Contributor

sachinchauhan2889 commented Jan 12, 2021 •

edited

Loading

Fixes #5881

Checklist

I have read the Contribution & Best practices Guide.
My branch is up-to-date with the Upstream development branch.
The acceptance, integration, unit tests and linter pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

sachinchauhan2889 added 2 commits

January 13, 2021 01:55


          roles

7bef1f4

fix

03f36d7

vercel bot commented Jan 12, 2021 •

edited

Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/hi2h2x97s
✅ Preview: https://open-event-frontend-git-fork-sachinchauhan2889-roles.eventyay.now.sh

vercel bot deployed to Preview

January 12, 2021 20:27

View deployment

sachinchauhan2889 changed the title ~~Roles~~ feat: allow deletion of roles

auto-label bot added the feature label

codecov bot commented Jan 12, 2021 •

edited

Loading

Codecov Report

Merging #6343 (4f6dc5b) into development (677c74b) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           development    #6343      +/-   ##
===============================================
- Coverage        22.90%   22.66%   -0.24%     
===============================================
  Files              524      520       -4     
  Lines             5786     5753      -33     
  Branches           113      113              
===============================================
- Hits              1325     1304      -21     
+ Misses            4434     4422      -12     
  Partials            27       27

Impacted Files	Coverage Δ
...pp/components/events/view/overview/manage-roles.js	`2.63% <0.00%> (-3.83%)`	⬇️
app/models/event.js	`31.57% <ø> (ø)`
app/routes/events/view/index.js	`0.00% <0.00%> (ø)`
app/routes/events/view/team/index.ts	`0.00% <ø> (ø)`
app/services/loader.ts	`25.96% <0.00%> (-5.77%)`	⬇️
app/services/l10n.js	`65.00% <0.00%> (-3.00%)`	⬇️
app/components/public/ticket-list.js	`19.67% <0.00%> (-2.30%)`	⬇️
app/components/forms/wizard/basic-details-step.js	`22.47% <0.00%> (-0.61%)`	⬇️
app/router.js	`100.00% <0.00%> (ø)`
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677c74b...b3f89c7. Read the comment docs.

iamareebjamal reviewed

View reviewed changes

app/templates/components/events/view/overview/manage-roles.hbs Outdated

    
                      </div>

                    {{/each}}

                    {{/if}}

                    {{#if (eq this.roleType 'accepted')}}

Member

iamareebjamal Jan 12, 2021

Why this check?

iamareebjamal reviewed

View reviewed changes

app/templates/components/events/view/overview/manage-roles.hbs Outdated

    
                      <tr>

                        <td>{{eventRole.user.email}}</td>

                        <td>{{eventRole.role.titleName}}</td>

                        {{#if (and @editable  (not-eq eventRole.role.titleName 'Owner'))}}

Member

iamareebjamal Jan 12, 2021

Check name, not title name


          fixs

aff547b

vercel bot deployed to Preview

January 13, 2021 08:55

View deployment

iamareebjamal reviewed

View reviewed changes

app/templates/components/events/view/overview/manage-roles.hbs Outdated

Comment on lines 28 to 29

    
                    {{#if (eq this.roleType 'pending')}}

                    {{#each this.roleInvites as |roleInvite|}}

Member

iamareebjamal Jan 13, 2021

indentation

iamareebjamal reviewed

View reviewed changes

app/templates/components/events/view/overview/manage-roles.hbs Outdated

Comment on lines 58 to 59

    
                    {{else}}

                    {{#each this.data.usersEventsRoles as |eventRole|}}

Member

iamareebjamal Jan 13, 2021

indentation


          identation

4f6dc5b

vercel bot deployed to Preview

January 14, 2021 04:47

View deployment

sachinchauhan2889 requested a review from iamareebjamal

January 14, 2021 04:48

iamareebjamal requested a review from maze-runnar

January 14, 2021 12:00

Contributor

maze-runnar commented Jan 14, 2021

I am getting error on deletion -
{"errors": [{"status": 500, "source": null, "title": "Unknown error", "detail": "Unknown error"}], "jsonapi": {"version": "1.0"}}


          Merge branch 'development' into roles

f98edb5

vercel bot deployed to Preview

January 16, 2021 22:38

View deployment

iamareebjamal reviewed

View reviewed changes

app/templates/components/events/view/overview/manage-roles.hbs Outdated Show resolved Hide resolved


          Update app/templates/components/events/view/overview/manage-roles.hbs

b3f89c7

iamareebjamal merged commit fb95f8d into fossasia:development

vercel bot deployed to Preview

January 16, 2021 22:43

View deployment

mariobehling changed the title ~~feat: allow deletion of roles~~ feat: allow deletion of team members

sachinchauhan2889 deleted the roles branch

February 10, 2021 16:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels