Skip to content

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented May 21, 2019

Fixes fossasia/open-event-frontend#2855 and fossasia/open-event-frontend#2974

Short description of what this resolves:

It removes recent schema checks to let cfs and ticket flow work like they used to

@auto-label auto-label bot added the fix label May 21, 2019
@mrsaicharan1
Copy link
Member

mrsaicharan1 commented May 21, 2019

@uds5501 Also, comment the lines for the test which deals with this in

app/api/validation/test_tickets.py

@uds5501
Copy link
Contributor Author

uds5501 commented May 21, 2019

@mrsaicharan1 Okay, will take out the corresponding tests too.

@uds5501 uds5501 force-pushed the remove-error-checks branch from a1be0f1 to 2409ea1 Compare May 21, 2019 11:42
@fossasia fossasia deleted a comment May 21, 2019
@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #5941 into development will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5941      +/-   ##
===============================================
- Coverage        66.39%   66.31%   -0.09%     
===============================================
  Files              286      286              
  Lines            13958    13922      -36     
===============================================
- Hits              9268     9232      -36     
  Misses            4690     4690
Impacted Files Coverage Δ
...l/integration/api/validation/test_speakers_call.py 97.14% <ø> (-0.73%) ⬇️
app/api/schema/tickets.py 88.73% <ø> (-0.88%) ⬇️
app/api/schema/speakers_calls.py 100% <ø> (ø) ⬆️
...sts/all/integration/api/validation/test_tickets.py 97.95% <ø> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35462b7...904ab04. Read the comment docs.

@uds5501
Copy link
Contributor Author

uds5501 commented May 21, 2019

@shreyanshdwivedi @mrsaicharan1 Please review

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@uds5501
Copy link
Contributor Author

uds5501 commented May 22, 2019

@CosmicCoder96 Please review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot edit FOSSASIA 2020 event: Error Message - ticket sales-ends-at should be before event ends-at

5 participants