fixes the broken order flow #5951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 24, 2019
abhinavk96
suggested changes
May 24, 2019
app/api/orders.py
Outdated
| elif current_user.id == order.user_id: | ||
| if order.status != 'pending': | ||
| print(order.status) | ||
| if order.status != 'initializing': |
Contributor
There was a problem hiding this comment.
This is again wrong. Pending orders can be updated. Users can pay and complete them.
Codecov Report
@@ Coverage Diff @@
## development #5951 +/- ##
===========================================
Coverage 66.4% 66.4%
===========================================
Files 285 285
Lines 13893 13893
===========================================
Hits 9225 9225
Misses 4668 4668
Continue to review full report at Codecov.
|
Member
Author
|
@CosmicCoder96 I've tried ordering a ticket -
However, when I tried to click on |
Contributor
|
It wasn’t present before. Maybe the PR which updated the dependencies
caused this. Either way please open an issue on FE to fix this. The library
might have changed after upgrade.
…On Fri, 24 May 2019 at 1:49 PM, Shreyansh Dwivedi ***@***.***> wrote:
@CosmicCoder96 <https://github.com/CosmicCoder96> I've tried ordering a
ticket -
- paid and free tickets for logged in user
- paid and free tickets for non-guest logged out user
- paid and free tickets for guest user
However, when I tried to click on Pay via card from non-superadmin
account, nothing happened and an error appeared on console - Error:
[ember-cli-stripe] Missing required key param. Don't know if this issue
was present earlier or not.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5951?email_source=notifications&email_token=AEDUDRMPHM6JHPIGP22P2M3PW6FYRA5CNFSM4HPMN3GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWEKDSQ#issuecomment-495493578>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEDUDRIFQ7DIYCQLVUB3F63PW6FYRANCNFSM4HPMN3GA>
.
|
abhinavk96
approved these changes
May 24, 2019
abhinavk96
changed the title
Contributor
|
Need to merge this urgently to find out other broken things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fossasia/open-event-frontend#2994
Checklist
developmentbranch.Short description of what this resolves:
Currently, order flow is broken due to one of the recent merged PR.