Skip to content

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented May 25, 2019

Fixes #5956

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Prior to this, no tickets were being generated locally and the download option was throwing error. Now it's not

@auto-label auto-label bot added the fix label May 25, 2019
@uds5501
Copy link
Contributor Author

uds5501 commented May 25, 2019

@shreyanshdwivedi Can you test this on your local?

:param order: The order for which to create tickets for.
"""
if order.status == 'completed':
if order.status == 'completed' or order.status == 'placed':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 👍

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #5957 into development will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           development   #5957   +/-   ##
===========================================
  Coverage         66.4%   66.4%           
===========================================
  Files              285     285           
  Lines            13893   13893           
===========================================
  Hits              9225    9225           
  Misses            4668    4668
Impacted Files Coverage Δ
app/api/helpers/order.py 38.7% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0844ad2...828e66d. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 0f0864e into fossasia:development May 25, 2019
@iamareebjamal
Copy link
Member

Rather than duplicating the logic this way. It should rather be a function in Order - is_fulfilled so that if in future the logic needs to change, it is localized to one place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No local pdf ticket/invoice being generated for PLACED orders

3 participants