Skip to content

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented May 29, 2019

Fixes #5837

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

This implements new sentry-sdk and removes the legacy raven[flask] dependency

@auto-label auto-label bot added the chore label May 29, 2019
@uds5501 uds5501 changed the title chore: implement new sentry sdk and remove raven dependency [WIP]chore: implement new sentry sdk and remove raven dependency May 29, 2019
@auto-label auto-label bot removed the chore label May 29, 2019
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #5967 into development will increase coverage by 0.06%.
The diff coverage is 36.36%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5967      +/-   ##
===============================================
+ Coverage        66.38%   66.45%   +0.06%     
===============================================
  Files              285      284       -1     
  Lines            13903    13902       -1     
===============================================
+ Hits              9230     9239       +9     
+ Misses            4673     4663      -10
Impacted Files Coverage Δ
app/api/events.py 26.09% <ø> (ø) ⬆️
app/__init__.py 86.39% <100%> (+0.08%) ⬆️
app/views/healthcheck.py 40% <12.5%> (ø) ⬆️
app/api/helpers/files.py 62.82% <0%> (-3.21%) ⬇️
tests/all/integration/api/helpers/test_files.py 99.11% <0%> (+13.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ccffb4...a96bfcf. Read the comment docs.

@uds5501
Copy link
Contributor Author

uds5501 commented May 29, 2019

@iamareebjamal review please

google-compute-engine~=2.8
factory_boy~=2.12
raven[flask]~=6.10
sentry-sdk[flask]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add version number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal
Copy link
Member

Please verify on a sentry project that it is working

@uds5501
Copy link
Contributor Author

uds5501 commented May 29, 2019

@iamareebjamal I have run it on my our project itself, I am attaching the logs :

image

@iamareebjamal
Copy link
Member

on my our project - my or our?

@iamareebjamal iamareebjamal changed the title [WIP]chore: implement new sentry sdk and remove raven dependency chore: implement new sentry sdk and remove raven dependency May 29, 2019
@auto-label auto-label bot added the chore label May 29, 2019
@iamareebjamal
Copy link
Member

Remove WIP status when it's ready for review

@uds5501
Copy link
Contributor Author

uds5501 commented May 29, 2019

@iamareebjamal on my own project (local repo) 😆

@iamareebjamal iamareebjamal merged commit a11a0d2 into fossasia:development May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate and verify new sentry SDK

4 participants