Skip to content

Conversation

@uds5501
Copy link
Contributor

@uds5501 uds5501 commented May 31, 2019

Fixes #5864

Changes proposed in this pull request:

  • add omise fields in events and settings schema descriptions
  • update response and requests accordingly in the docs

@auto-label auto-label bot added the docs label May 31, 2019
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #5979 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5979   +/-   ##
============================================
  Coverage        66.45%   66.45%           
============================================
  Files              284      284           
  Lines            13902    13902           
============================================
  Hits              9239     9239           
  Misses            4663     4663

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f94589...3243645. Read the comment docs.

@uds5501
Copy link
Contributor Author

uds5501 commented May 31, 2019

@mrsaicharan1 @iamareebjamal please review?

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iamareebjamal iamareebjamal merged commit eae8525 into fossasia:development Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update API docs for Omise payment Gateway fields

3 participants