fix: migration split heads are sequential now #5984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@iamareebjamal Please review |
Codecov Report
@@ Coverage Diff @@
## development #5984 +/- ##
==============================================
Coverage ? 66.46%
==============================================
Files ? 284
Lines ? 13905
Branches ? 0
==============================================
Hits ? 9242
Misses ? 4663
Partials ? 0Continue to review full report at Codecov.
|
kushthedude
approved these changes
Jun 2, 2019
shreyanshdwivedi
approved these changes
Jun 2, 2019
kushthedude
suggested changes
Jun 2, 2019
Member
kushthedude
left a comment
kushthedude
left a comment
There was a problem hiding this comment.
@uds5501 Please check , After pulling your changes i still get this
File "/usr/local/lib/python3.7/site-packages/alembic/script/revision.py", line 394, in filter_for_lineage
id_, branch_label = self._resolve_revision_number(check_against)
File "/usr/local/lib/python3.7/site-packages/alembic/script/revision.py", line 445, in _resolve_revision_number
current_head = self.get_current_head(branch_label)
File "/usr/local/lib/python3.7/site-packages/alembic/script/revision.py", line 271, in get_current_head
"%s@head" % branch_label if branch_label else "head")
alembic.util.exc.CommandError: Multiple heads are present; please specify a single target revision
Contributor
Author
|
That's wierd, @shreyanshdwivedi can you check? Travis build passed so it shouldn't be a problem |
Member
|
@uds5501 My heads are still diff |
Member
|
Please tell output of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5983
Checked this migration, works on local.