-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Added required fields and schemas for ngo events #5995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
migrations/versions/c517c6be040d_.py
Outdated
|
|
||
| def upgrade(): | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.add_column('events', sa.Column('is_ngo', sa.Boolean(), nullable=True)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nullable=False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RC
Updated 👍
iamareebjamal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RC
|
The migration will fail |
Is it essential to mention |
|
Yes, but not related to migration. The migration will fail because default value is not supplied in the migration |
Codecov Report
@@ Coverage Diff @@
## development #5995 +/- ##
===============================================
+ Coverage 66.28% 66.28% +<.01%
===============================================
Files 285 285
Lines 13992 13995 +3
===============================================
+ Hits 9274 9277 +3
Misses 4718 4718
Continue to review full report at Codecov.
|
Part of #5991
Checklist
developmentbranch.Short description of what this resolves:
Changes proposed in this pull request: