fix: minor typo and add omise to payment-mode schema #6002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@iamareebjamal Please review and close |
mrsaicharan1
previously approved these changes
Jun 5, 2019
Contributor
Author
|
Just a sec, let me add one more check which was missed here. |
uds5501
changed the title
houndci-bot
reviewed
Jun 5, 2019
Codecov Report
@@ Coverage Diff @@
## development #6002 +/- ##
============================================
Coverage 66.28% 66.28%
============================================
Files 285 285
Lines 13995 13995
============================================
Hits 9277 9277
Misses 4718 4718
Continue to review full report at Codecov.
|
Contributor
Author
|
@mrsaicharan1 @shreyanshdwivedi @iamareebjamal please review |
iamareebjamal
changed the title
uds5501
force-pushed
the
typo-omise-schema
branch
from
9a6b2db to
7d230f9
Compare
iamareebjamal
approved these changes
Jun 5, 2019
kushthedude
approved these changes
Jun 6, 2019
shreyanshdwivedi
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6003
Checklist
There was a typo in settings schema regarding omise activation