feat: Omise charge route and payment flow #6004

mrsaicharan1 · 2019-06-05T20:06:13Z

Frontend: fossasia/open-event-frontend#3073**
Fixes #5823

Checklist

I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream development branch.
The unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

This creates a charge route for Omise which handles the details from FE, creates a charge object and authorises the payment. This gateway does not require redirection, therefore, can easily be integrated with the android app.

Changes proposed in this pull request:

Create charge route
Handled all possible exceptions and errors with logging

app/api/orders.py

houndci-bot · 2019-06-05T20:06:19Z

app/api/orders.py

    except TypeError:
        return jsonify(status=False, error='Source object status error')
+
+@order_misc_routes.route('/orders/<string:order_identifier>/omise-checkout', methods=['POST', 'GET'])


expected 2 blank lines, found 1

app/api/orders.py

codecov · 2019-06-05T20:32:12Z

Codecov Report

Merging #6004 into development will decrease coverage by 0.1%.
The diff coverage is 21.87%.

@@               Coverage Diff               @@
##           development    #6004      +/-   ##
===============================================
- Coverage        66.26%   66.16%   -0.11%     
===============================================
  Files              285      285              
  Lines            14007    14038      +31     
===============================================
+ Hits              9282     9288       +6     
- Misses            4725     4750      +25

Impacted Files	Coverage Δ
app/api/orders.py	`31.48% <19.04%> (-1.32%)`	⬇️
app/api/helpers/payment.py	`28.03% <27.27%> (-0.09%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c2400...5fbc0ac. Read the comment docs.

houndci-bot · 2019-06-05T21:22:54Z

app/api/orders.py

+    token = request.form.get("omiseToken")
+    try:
+        charge = OmisePaymentsManager.charge_payment(order_identifier, token)
+    except omise.errors.BaseError as e:


undefined name 'omise'

app/api/helpers/payment.py

houndci-bot · 2019-06-05T21:22:54Z

app/api/helpers/payment.py

                 )
        return charge
+
+class OmisePaymentsManager(object):


expected 2 blank lines, found 1

uds5501 · 2019-06-06T05:55:42Z

app/api/orders.py

+    try:
+        charge = OmisePaymentsManager.charge_payment(order_identifier, token)
+    except omise.errors.BaseError as e:
+        logging.error(f"""OmiseError: {repr(e)}.  See https://www.omise.co/api-errors""")


please make the syntax python 3.6 compatible

Upgrade your python please

app/api/helpers/payment.py

iamareebjamal · 2019-06-06T14:18:38Z

Omise docs needs the amount to be in integer so we should make it
amount=int(order.amount)

Umm, so if the order amount is 4.99 dollars, I only charge 4 dollars?

Makes no sense actually

app/api/helpers/payment.py

mrsaicharan1 · 2019-06-07T15:13:17Z

@iamareebjamal Please check.

iamareebjamal · 2019-06-07T18:22:26Z

Peer Review First

mrsaicharan1 · 2019-06-07T19:55:02Z

@uds5501 @shreyanshdwivedi Please review this.

uds5501

Looks good. just take down hound errors please

shreyanshdwivedi

LGTM 👍

mrsaicharan1 · 2019-06-08T12:29:13Z

Looks good. just take down hound errors please

There are no hound errors! :D

mrsaicharan1 · 2019-06-14T11:11:03Z

@iamareebjamal Updated with dev branch rebase. Please merge this.

Omise Addition requirements Shifted to payments module Final omise Round off amount Omise final

houndci-bot reviewed Jun 5, 2019

View reviewed changes

mrsaicharan1 force-pushed the omise-backend branch from 4d6de82 to 3de47d1 Compare June 5, 2019 20:09

houndci-bot reviewed Jun 5, 2019

View reviewed changes

app/api/orders.py Outdated Show resolved Hide resolved

app/api/orders.py Outdated Show resolved Hide resolved

app/api/orders.py Outdated Show resolved Hide resolved

mrsaicharan1 force-pushed the omise-backend branch 2 times, most recently from c723181 to a971509 Compare June 5, 2019 20:15

houndci-bot reviewed Jun 5, 2019

View reviewed changes

app/api/orders.py Outdated Show resolved Hide resolved

app/api/orders.py Outdated Show resolved Hide resolved

mrsaicharan1 force-pushed the omise-backend branch 3 times, most recently from 8efb0ca to e198957 Compare June 5, 2019 20:20

mrsaicharan1 changed the title ~~[wip]feat: Omise charge route and error handling~~ feat: Omise charge route and error handling Jun 5, 2019

auto-label bot added the feature label Jun 5, 2019

mrsaicharan1 changed the title ~~feat: Omise charge route and error handling~~ feat: Omise charge route and payment flow Jun 5, 2019

mrsaicharan1 force-pushed the omise-backend branch from e198957 to bf1443d Compare June 5, 2019 21:22

houndci-bot reviewed Jun 5, 2019

View reviewed changes

mrsaicharan1 force-pushed the omise-backend branch 3 times, most recently from 29607d4 to 8ec6f20 Compare June 5, 2019 21:25

uds5501 suggested changes Jun 6, 2019

View reviewed changes

app/api/helpers/payment.py Outdated Show resolved Hide resolved

app/api/helpers/payment.py Outdated Show resolved Hide resolved

mrsaicharan1 force-pushed the omise-backend branch 2 times, most recently from e85220b to bd16931 Compare June 6, 2019 08:30

mrsaicharan1 force-pushed the omise-backend branch 2 times, most recently from 8344c80 to 014da3b Compare June 6, 2019 19:00

houndci-bot reviewed Jun 6, 2019

View reviewed changes

app/api/helpers/payment.py Outdated Show resolved Hide resolved

mrsaicharan1 force-pushed the omise-backend branch 2 times, most recently from b26aa65 to 159d70d Compare June 7, 2019 15:13

fossasia deleted a comment Jun 7, 2019

uds5501 previously approved these changes Jun 8, 2019

View reviewed changes

shreyanshdwivedi previously approved these changes Jun 8, 2019

View reviewed changes

iamareebjamal previously approved these changes Jun 9, 2019

View reviewed changes

Added omise checkout route logic

00901c3

Omise Addition requirements Shifted to payments module Final omise Round off amount Omise final

mrsaicharan1 dismissed stale reviews from iamareebjamal, shreyanshdwivedi, and uds5501 via 00901c3 June 14, 2019 11:22

mrsaicharan1 force-pushed the omise-backend branch from 5fbc0ac to 00901c3 Compare June 14, 2019 11:22

iamareebjamal approved these changes Jun 14, 2019

View reviewed changes

iamareebjamal merged commit a6b7ae0 into fossasia:development Jun 14, 2019

feat: Omise charge route and payment flow #6004

feat: Omise charge route and payment flow #6004

Uh oh!

Conversation

mrsaicharan1 commented Jun 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Short description of what this resolves:

Changes proposed in this pull request:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

houndci-bot Jun 5, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

houndci-bot Jun 5, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

houndci-bot Jun 5, 2019

Choose a reason for hiding this comment

Uh oh!

uds5501 Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Jun 6, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

iamareebjamal commented Jun 6, 2019

Uh oh!

Uh oh!

mrsaicharan1 commented Jun 7, 2019

Uh oh!

iamareebjamal commented Jun 7, 2019

Uh oh!

mrsaicharan1 commented Jun 7, 2019

Uh oh!

uds5501 left a comment

Choose a reason for hiding this comment

Uh oh!

shreyanshdwivedi left a comment

Choose a reason for hiding this comment

Uh oh!

mrsaicharan1 commented Jun 8, 2019

Uh oh!

mrsaicharan1 commented Jun 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mrsaicharan1 commented Jun 5, 2019 •

edited

Loading

codecov bot commented Jun 5, 2019 •

edited

Loading

mrsaicharan1 commented Jun 14, 2019 •

edited

Loading