-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: restricts unverified user for buying free tickets #6008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e074cd0 to
c14f4cb
Compare
|
@shreyanshdwivedi Are you sure all mentors have approved it because this will break the flow for Guest Order Form ? |
|
@kushthedude please refer to the issue mentioned and @iamareebjamal asked me to add this check on server later in that issue itself. |
c14f4cb to
e2a0ef4
Compare
Codecov Report
@@ Coverage Diff @@
## development #6008 +/- ##
===============================================
- Coverage 66.29% 66.25% -0.04%
===============================================
Files 285 285
Lines 13997 14004 +7
===============================================
Hits 9279 9279
- Misses 4718 4725 +7
Continue to review full report at Codecov.
|
|
@mrsaicharan1 @iamareebjamal @uds5501 @kushthedude please review |
Anupam-dagar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyanshdwivedi looks good to me.
iamareebjamal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
e2a0ef4 to
0fdfae5
Compare
0fdfae5 to
c65e79d
Compare
|
@uds5501 @iamareebjamal I've updated the checks. Please review |
|
@shreyanshdwivedi , Why did we restrict the orders of a combination of Paid and Free Tickets for unverified users? |
|
@kushthedude beacuse the issue I mentioned asked to apply check on free tickets - not free orders |
|
@shreyanshdwivedi @iamareebjamal Shouldn't we restrict free orders rather than free tickets ? |
Related to fossasia/open-event-attendee-android#1881 (comment)
Checklist
developmentbranch.Changes proposed in this pull request:
It adds a check to restrict an unverified user from buying free tickets