Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

Related to fossasia/open-event-attendee-android#1881 (comment)

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Changes proposed in this pull request:

It adds a check to restrict an unverified user from buying free tickets

@auto-label auto-label bot added the feature label Jun 7, 2019
@kushthedude
Copy link
Member

@shreyanshdwivedi Are you sure all mentors have approved it because this will break the flow for Guest Order Form ?

@shreyanshdwivedi
Copy link
Member Author

shreyanshdwivedi commented Jun 7, 2019

@kushthedude please refer to the issue mentioned and @iamareebjamal asked me to add this check on server later in that issue itself.
Also, I've checked for guest orders, it'll only stop them from buying free tickets. Paid tickets can be bought. Please check
Edit: I'll fix travis till then

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #6008 into development will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6008      +/-   ##
===============================================
- Coverage        66.29%   66.25%   -0.04%     
===============================================
  Files              285      285              
  Lines            13997    14004       +7     
===============================================
  Hits              9279     9279              
- Misses            4718     4725       +7
Impacted Files Coverage Δ
app/api/attendees.py 37.22% <0%> (-2.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf70d6...c65e79d. Read the comment docs.

@shreyanshdwivedi
Copy link
Member Author

@mrsaicharan1 @iamareebjamal @uds5501 @kushthedude please review

Copy link
Member

@Anupam-dagar Anupam-dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyanshdwivedi looks good to me.

Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@fossasia fossasia deleted a comment Jun 7, 2019
@shreyanshdwivedi
Copy link
Member Author

@uds5501 @iamareebjamal I've updated the checks. Please review

@niranjan94 niranjan94 merged commit 386ecc6 into fossasia:development Jun 9, 2019
@kushthedude
Copy link
Member

kushthedude commented Jun 12, 2019

@shreyanshdwivedi , Why did we restrict the orders of a combination of Paid and Free Tickets for unverified users?

@shreyanshdwivedi
Copy link
Member Author

@kushthedude beacuse the issue I mentioned asked to apply check on free tickets - not free orders

@kushthedude
Copy link
Member

@shreyanshdwivedi @iamareebjamal Shouldn't we restrict free orders rather than free tickets ?

@shreyanshdwivedi shreyanshdwivedi deleted the freeTicket branch June 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants