Skip to content

Conversation

@mrsaicharan1
Copy link
Member

Fixes #5968

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Implemented organizer access for attendee tickets

Changes proposed in this pull request:

  • Pulled organizer ids and checked if the current user was the organizer or the event attendee

@auto-label auto-label bot added the fix label Jun 10, 2019
@mrsaicharan1 mrsaicharan1 changed the title fix: Implemented organizer access for invoices fix: Implemented organizer access for attendee tickets Jun 10, 2019
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a helper method in event so that no duplication happens

@mrsaicharan1 mrsaicharan1 force-pushed the org-fix branch 3 times, most recently from 29dddad to 907409e Compare June 11, 2019 08:21
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #6024 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6024      +/-   ##
===============================================
- Coverage        66.27%   66.26%   -0.01%     
===============================================
  Files              285      285              
  Lines            14010    14011       +1     
===============================================
  Hits              9285     9285              
- Misses            4725     4726       +1
Impacted Files Coverage Δ
app/api/auth.py 21.3% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f192ad5...f2dd782. Read the comment docs.

@mrsaicharan1
Copy link
Member Author

@uds5501 @shreyanshdwivedi @iamareebjamal Please check.

@mrsaicharan1 mrsaicharan1 force-pushed the org-fix branch 2 times, most recently from 8ad359c to f2dd782 Compare June 13, 2019 15:02
@fossasia fossasia deleted a comment Jun 13, 2019
app/api/auth.py Outdated
})


# helper methods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal Updated.

created helper function for org check

moved function to models

replaced own function with predefined
@iamareebjamal iamareebjamal merged commit 172011e into fossasia:development Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Organizer should be able to download tickets of attendees

3 participants