feat: Add an admin-only endpoint for test mail #6041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavk96
force-pushed
the
development
branch
2 times, most recently
from
a0f5f8b to
eb4db7c
Compare
Codecov Report
@@ Coverage Diff @@
## development #6041 +/- ##
==============================================
Coverage ? 66.15%
==============================================
Files ? 285
Lines ? 14063
Branches ? 0
==============================================
Hits ? 9304
Misses ? 4759
Partials ? 0
Continue to review full report at Codecov.
|
app/api/settings.py
Outdated
| @admin_misc_routes.route('/test-mail', methods=['POST']) | ||
| def test_email_setup(): | ||
| if 'Authorization' in request.headers: | ||
| _jwt_required(app.config['JWT_DEFAULT_REALM']) |
abhinavk96
force-pushed
the
development
branch
2 times, most recently
from
3ed2419 to
6cc3b6f
Compare
Contributor
Author
|
@iamareebjamal I completely forgot about the custom decorators, have updated the PR. |
app/api/settings.py
Outdated
| recipient = request.json['recipient'] | ||
| except KeyError: | ||
| return UnprocessableEntityError( | ||
| {'source': ''}, 'Invalid request payload').respond() |
Member
There was a problem hiding this comment.
Better to only use exception handling in exceptional cases
recipient = request.json.get('recipient')
if not recipient:
return UnprocessableEntityError({'source': 'recipient'}, 'Required parameter recipient not found').respond() // explicit error message
# continue with happy path
Contributor
Author
|
@iamareebjamal Thanks for the review, I have made the changes. |
iamareebjamal
previously approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6040
Changes proposed in this pull request: