test: Shifted admin check function and added integration test

[mrsaicharan1]

Part of #5320

Short description of what this resolves:

This moves the admin rights function to the helpers and adds a test to check it

Changes proposed in this pull request:

• Shifted helper function
• Added integration test

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream development branch.
• The unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

• All the functions created/modified in this PR contain relevant docstrings.

[poush]

I think you should also test with admin=False

[poush]

You can create two users and one admin and other non-admin and this should give correct response for each of them

[mrsaicharan1]

@poush Made the requested changes. Please have a look

[mrsaicharan1]

@poush Will do that :)

…

On Thu, 20 Jun 2019 at 12:41 PM, Piyush Agrawal ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/api/helpers/auth.py <#6081 (comment)> : > @@ -31,3 +31,14 @@ def is_verified_user(): @staticmethod def is_accessible(): return current_user.is_authenticated + + @staticmethod + def check_auth_admin(username, password): + # This function is called to check for proper authentication & admin rights + if username and password: + user = User.query.filter_by(_email=username).first() + if user: + if user.is_correct_password(password): + if user.is_admin: Hi @mrsaicharan1 <https://github.com/mrsaicharan1>, I think its better that lines 40, 41, 41 be reduced to only 1 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6081?email_source=notifications&email_token=AGAHUW25H7RCWMJURRM77QLP3MUTVA5CNFSM4HZQCQGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4DRW6A#pullrequestreview-252124024>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGAHUW2FNYDV5CGY5XFGHUDP3MUTVANCNFSM4HZQCQGA> .

[mrsaicharan1]

Yeah two test cases. Agreed

…

On Thu, 20 Jun 2019 at 12:51 PM, Shreyansh Dwivedi ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/api/helpers/auth.py <#6081 (comment)> : > @@ -31,3 +31,14 @@ def is_verified_user(): @staticmethod def is_accessible(): return current_user.is_authenticated + + @staticmethod + def check_auth_admin(username, password): + # This function is called to check for proper authentication & admin rights + if username and password: + user = User.query.filter_by(_email=username).first() + if user: + if user.is_correct_password(password): + if user.is_admin: @mrsaicharan1 <https://github.com/mrsaicharan1> yes please use and and combine the logics — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6081?email_source=notifications&email_token=AGAHUW42G32G6L7VNJZSYATP3MVW7A5CNFSM4HZQCQGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4DSRCA#discussion_r295673838>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGAHUW2MZTCP546JBGYKU4TP3MVW7ANCNFSM4HZQCQGA> .

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (development@c10a3fc). Click here to learn what that means.
The diff coverage is 95%.

@@              Coverage Diff               @@
##             development    #6081   +/-   ##
==============================================
  Coverage               ?   66.17%           
==============================================
  Files                  ?      285           
  Lines                  ?    14133           
  Branches               ?        0           
==============================================
  Hits                   ?     9353           
  Misses                 ?     4780           
  Partials               ?        0

Impacted Files	Coverage Δ
tests/all/integration/api/helpers/test_auth.py	97.91% <100%> (ø)
app/api/helpers/auth.py	92% <100%> (ø)
app/api/auth.py	23.34% <50%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10a3fc...146bad8. Read the comment docs.

[mrsaicharan1]

@shreyanshdwivedi @uds5501 @poush @iamareebjamal Made the suggested changes. Please have a look now.