-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: modify cancel notif message and add required links #6084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modify cancel notif message and add required links #6084
Conversation
9597d90 to
f22b484
Compare
Codecov Report
@@ Coverage Diff @@
## development #6084 +/- ##
==============================================
+ Coverage 66.17% 66.2% +0.03%
==============================================
Files 285 285
Lines 14133 14134 +1
==============================================
+ Hits 9353 9358 +5
+ Misses 4780 4776 -4
Continue to review full report at Codecov.
|
|
@mrsaicharan1 @shreyanshdwivedi Please review! |
|
@CosmicCoder96 @iamareebjamal Please take a look? |
mrsaicharan1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that cancelled/expired tickets don't have any vacancy. How is it that you're planning for that
|
@mrsaicharan1 I don't think we need to do anything for that. The issue required a ticket link and I provided that. A cancelled order having no ticket holders is as it is supposed to be. Any cancelled ticket should be relocated so that it's available for sale. |
Agreed |
mrsaicharan1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #6085
Changes proposed in this pull request:
Checklist
developmentbranch.Notifications after the change :