Skip to content

Conversation

@iamareebjamal
Copy link
Member

No description provided.

@auto-label auto-label bot added the chore label Jun 22, 2019
@iamareebjamal
Copy link
Member Author

We need to be able to debug apps depoyed on heroku. @CosmicCoder96 @niranjan94 Please tell if this can create any problems

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #6092 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6092   +/-   ##
============================================
  Coverage        66.17%   66.17%           
============================================
  Files              285      285           
  Lines            14133    14133           
============================================
  Hits              9353     9353           
  Misses            4780     4780

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d69104...3102d4c. Read the comment docs.

@abhinavk96
Copy link
Contributor

@iamareebjamal I don't think this will be a problem -- just a question, does running the server on development limit it's scalability? Heroku is used for travis testing, often multiple PRs send a large amount of requests to it. If it can take that without timing out, it's fine I guess.

@mariobehling mariobehling merged commit 5b7c398 into fossasia:development Jun 22, 2019
@iamareebjamal
Copy link
Member Author

@CosmicCoder96 Let's check if it creates a problem. If so, we'll revert

@iamareebjamal iamareebjamal deleted the heroku-dev branch June 22, 2019 12:07
iamareebjamal added a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants