Skip to content

Conversation

@abhinavk96
Copy link
Contributor

@abhinavk96 abhinavk96 commented Jun 26, 2019

Fixes #6109

Changes proposed in this pull request:

  • Fixes flawed attendee access control logic
  • allows recreation of invoice file, in case it does not exist, otherwise, it just crashed.

@auto-label auto-label bot added the fix label Jun 26, 2019
@abhinavk96 abhinavk96 requested a review from iamareebjamal June 26, 2019 14:56
@abhinavk96 abhinavk96 changed the title fix: resolve error on multi-attendee downloads fix: resolve error on multi-attendee invoice downloads Jun 26, 2019
@abhinavk96 abhinavk96 requested a review from mariobehling June 26, 2019 14:58
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #6110 into development will decrease coverage by <.01%.
The diff coverage is 10%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6110      +/-   ##
===============================================
- Coverage         66.2%   66.19%   -0.01%     
===============================================
  Files              285      285              
  Lines            14197    14198       +1     
===============================================
  Hits              9399     9399              
- Misses            4798     4799       +1
Impacted Files Coverage Δ
app/api/auth.py 24.12% <10%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d1b13...89acb2b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #6110 into development will decrease coverage by <.01%.
The diff coverage is 10%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6110      +/-   ##
===============================================
- Coverage         66.2%   66.19%   -0.01%     
===============================================
  Files              285      285              
  Lines            14197    14198       +1     
===============================================
  Hits              9399     9399              
- Misses            4798     4799       +1
Impacted Files Coverage Δ
app/api/auth.py 24.12% <10%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d1b13...89acb2b. Read the comment docs.

@iamareebjamal iamareebjamal merged commit cf03f65 into fossasia:development Jun 26, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-attendee invoice download fails

2 participants