fix: make billing info mandatory for paid orders

[shreyanshdwivedi]

Fixes #6137

Short description of what this resolves:

Make billing information mandatory for paid orders

Changes proposed in this pull request:

• Adds checks in before_create_object and before_update_object in api/orders.py

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream development branch.
• The unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

• All the functions created/modified in this PR contain relevant docstrings.

[codecov]

Codecov Report

Merging #6192 into development will decrease coverage by 0.02%.
The diff coverage is 14.28%.

@@               Coverage Diff               @@
##           development    #6192      +/-   ##
===============================================
- Coverage        65.29%   65.27%   -0.03%     
===============================================
  Files              287      287              
  Lines            14704    14711       +7     
===============================================
+ Hits              9601     9602       +1     
- Misses            5103     5109       +6

Impacted Files	Coverage Δ
app/api/orders.py	28.43% <14.28%> (-0.33%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5949dc6...2a98f9b. Read the comment docs.

[codecov]

Codecov Report

Merging #6192 into development will decrease coverage by 0.03%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           development    #6192      +/-   ##
===============================================
- Coverage           66%   65.96%   -0.04%     
===============================================
  Files              288      288              
  Lines            14521    14529       +8     
===============================================
  Hits              9584     9584              
- Misses            4937     4945       +8

Impacted Files	Coverage Δ
app/api/orders.py	29.61% <0%> (-0.85%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf208e...4ba2903. Read the comment docs.

[iamareebjamal]

I think you made a method which checks the payment mode, use that. If there's no method, create one to avoid repetition

[shreyanshdwivedi]

Yeah that function was to check if any of the payment option is enabled in event, both online and offline form of payments.
But here I need to check if the order is paid via our platform i.e. stripe, omise, alipay or paypal. When order is crrated, I don't think that we can check it via a method. However while updating, we might check via a method.

[shreyanshdwivedi]

@iamareebjamal should I add a new function just to check if payment options are from stripe, omise, alipay or paypal?

[iamareebjamal]

I see repeated code. There should be one function called from 2 places instead of repetition

[shreyanshdwivedi]

@iamareebjamal made a function check_billing_info to remove the code duplication. Please have a look

[iamareebjamal]

Have a peer review

[shreyanshdwivedi]

@mrsaicharan1 @uds5501 @kushthedude please review

[kushthedude]

@shreyanshdwivedi There is one hound violation.

[shreyanshdwivedi]

@uds5501 @mrsaicharan1 @kushthedude please review

[mrsaicharan1]

LGTM

[prateekj117]

LGTM

[shreyanshdwivedi]

@iamareebjamal please review. Updated the exception

[shreyanshdwivedi]

@CosmicCoder96 I have a query. The issue for which I opened this PR doesn't state whether the billing Info is required for only orders paid via our platform or even for offline paid event. Do you want it for both online as well as offline paid events?

[shreyanshdwivedi]

Keep it on hold till @CosmicCoder96 replies to #6192 (comment)

[shreyanshdwivedi]

@iamareebjamal I've just updated the check to include all type of paid orders - data.get('amount') > 0 as we are following this on FE too.