Skip to content

chore: Migrate to flask_jwt_extended #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2019
Merged

chore: Migrate to flask_jwt_extended #6216

merged 4 commits into from
Jul 20, 2019

Conversation

@iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Jul 19, 2019 •
edited
Loading

No description provided.

houndci-bot
houndci-bot reviewed Jul 19, 2019
View reviewed changes
@auto-label auto-label bot added the chore label Jul 19, 2019
@iamareebjamal iamareebjamal changed the base branch from master to development July 19, 2019 21:36
@codecov
Copy link

codecov bot commented Jul 20, 2019

Codecov Report

Merging #6216 into development will increase coverage by 0.01%.
The diff coverage is 62.88%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6216      +/-   ##
===============================================
+ Coverage        65.93%   65.94%   +0.01%     
===============================================
  Files              288      288              
  Lines            14552    14558       +6     
===============================================
+ Hits              9595     9601       +6     
  Misses            4957     4957
Impacted Files Coverage Δ
app/api/helpers/ticketing.py 16.21% <ø> (-0.75%) ⬇️
app/api/auth.py 23.88% <100%> (ø) ⬆️
app/__init__.py 87.36% <100%> (+0.28%) ⬆️
app/api/helpers/jwt.py 96% <100%> (+0.34%) ⬆️
app/api/helpers/export_helpers.py 42.17% <100%> (ø) ⬆️
app/api/users.py 31.32% <100%> (ø) ⬆️
app/api/uploads.py 30.55% <100%> (ø) ⬆️
app/api/helpers/import_helpers.py 27.38% <100%> (ø) ⬆️
app/api/exports.py 24% <100%> (ø) ⬆️
app/api/orders.py 30.46% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f14d5...3b85713. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 20, 2019 •
edited
Loading

Codecov Report

Merging #6216 into development will decrease coverage by 0.04%.
The diff coverage is 61.65%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6216      +/-   ##
===============================================
- Coverage        65.93%   65.88%   -0.05%     
===============================================
  Files              288      288              
  Lines            14552    14575      +23     
===============================================
+ Hits              9595     9603       +8     
- Misses            4957     4972      +15
Impacted Files Coverage Δ
app/api/helpers/ticketing.py 16.21% <ø> (-0.75%) ⬇️
app/__init__.py 87.15% <100%> (+0.07%) ⬆️
tests/all/integration/api/helpers/test_jwt.py 96.96% <100%> (ø) ⬆️
app/api/helpers/export_helpers.py 42.17% <100%> (ø) ⬆️
app/api/users.py 31.32% <100%> (ø) ⬆️
app/api/uploads.py 30.55% <100%> (ø) ⬆️
app/api/helpers/import_helpers.py 27.38% <100%> (ø) ⬆️
app/api/exports.py 24% <100%> (ø) ⬆️
app/api/orders.py 30.46% <100%> (ø) ⬆️
app/api/admin_statistics_api/events.py 75% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f14d5...e8c014c. Read the comment docs.

houndci-bot
houndci-bot reviewed Jul 20, 2019
View reviewed changes
@fossasia fossasia deleted a comment Jul 20, 2019
@fossasia fossasia deleted a comment Jul 20, 2019
@iamareebjamal iamareebjamal changed the title chore: Change to flask_jwt_extended (Pass 1) chore: Migrate to flask_jwt_extended Jul 20, 2019
@iamareebjamal iamareebjamal merged commit 5a3ea1a into fossasia:development Jul 20, 2019
@iamareebjamal iamareebjamal deleted the jwt-extended branch July 20, 2019 20:54
abhinavk96
abhinavk96 reviewed Aug 1, 2019
View reviewed changes
app/api/helpers/ticketing.py
@@ -1,7 +1,5 @@
from datetime import datetime

from flask_jwt import current_identity as current_user
Copy link
Contributor

@abhinavk96 abhinavk96 Aug 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal This was an oversight right? I think this is causing a 500 which is causing #6283

Copy link
Contributor

@abhinavk96 abhinavk96 Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current_user became undefined after this.

Copy link
Member Author

@iamareebjamal iamareebjamal Aug 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my mistake. I thought this was covered by tests and did a Find/Replace. Not know how it slipped

iamareebjamal added a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
@iamareebjamal
chore: Migrate to flask_jwt_extended (fossasia#6216)
5317d55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@abhinavk96 abhinavk96 abhinavk96 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iamareebjamal @houndci-bot @abhinavk96