fix: state logic error in sessions.py #6220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> if data['state'] is not 'draft' or not 'pending':
The second half of this if statement is __always__ False because __python -c "print(not 'pending')"__ # --> False
The correct ways to write this line are:
```python
if data['state'] != 'draft' or data['state'] != 'pending':
# or better yet...
if data['state'] not in ('draft', 'pending'):
```
Codecov Report
@@ Coverage Diff @@
## development #6220 +/- ##
============================================
Coverage 65.93% 65.93%
============================================
Files 288 288
Lines 14552 14552
============================================
Hits 9595 9595
Misses 4957 4957
Continue to review full report at Codecov.
|
iamareebjamal
changed the title
iamareebjamal
approved these changes
Jul 20, 2019
iamareebjamal
pushed a commit
to iamareebjamal/open-event-server
that referenced
this pull request
Aug 2, 2019
> if data['state'] is not 'draft' or not 'pending':
The second half of this if statement is __always__ False because __python -c "print(not 'pending')"__ # --> False
The correct ways to write this line are:
```python
if data['state'] != 'draft' or data['state'] != 'pending':
# or better yet...
if data['state'] not in ('draft', 'pending'):
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second half of this if statement is always False because:
python -c "print(not 'pending')"
The correct ways to write this line are:
Fixes #
Short description of what this resolves:
Changes proposed in this pull request:
Checklist
developmentbranch.