Skip to content

Conversation

@mrsaicharan1
Copy link
Member

Part of #6223

Short description of what this resolves:

  • Moves utility unit tests to the appropriate folder with appropriate changes in tests

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jul 22, 2019
@mrsaicharan1 mrsaicharan1 changed the title fix: Moved all utilities unit tests to appropriate folder fix: Moved utility unit tests to appropriate folder Jul 22, 2019
@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #6226 into development will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6226      +/-   ##
===============================================
- Coverage        65.88%   65.86%   -0.03%     
===============================================
  Files              288      287       -1     
  Lines            14573    14559      -14     
===============================================
- Hits              9602     9589      -13     
+ Misses            4971     4970       -1
Impacted Files Coverage Δ
tests/all/unit/api/helpers/test_utilities.py 98.21% <100%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4467fe3...41eadcb. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix: Moved utility unit tests to appropriate folder chore: Moved utility unit tests to appropriate folder Jul 22, 2019
@auto-label auto-label bot added chore and removed fix labels Jul 22, 2019
@mrsaicharan1
Copy link
Member Author

@uds5501 @shreyanshdwivedi Please review this

@iamareebjamal iamareebjamal merged commit 0a1849a into fossasia:development Jul 23, 2019
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants