fix: Replaced hardcoded with FE URL from settings #6233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamareebjamal
approved these changes
Jul 24, 2019
shreyanshdwivedi
approved these changes
Jul 24, 2019
| event_name=order.event.name, | ||
| invoice_id=order.invoice_number | ||
| invoice_id=order.invoice_number, | ||
| frontend_url=get_settings()['frontend_url'] |
Member
There was a problem hiding this comment.
Maybe in other issue, but this needs to be in context processor
Codecov Report
@@ Coverage Diff @@
## development #6233 +/- ##
===============================================
- Coverage 65.86% 65.71% -0.15%
===============================================
Files 287 286 -1
Lines 14559 14523 -36
===============================================
- Hits 9589 9544 -45
- Misses 4970 4979 +9
Continue to review full report at Codecov.
|
yitzikc
pushed a commit
to yitzikc/open-event-server
that referenced
this pull request
Jul 25, 2019
mrsaicharan1
added a commit
to mrsaicharan1/open-event-server
that referenced
this pull request
Jul 26, 2019
implemented route for component check Fix hound issues Added Additonal table & relationship Add URL rules & schema additions Fix hound issues Removed redundant relations
mrsaicharan1
added a commit
to mrsaicharan1/open-event-server
that referenced
this pull request
Jul 26, 2019
implemented route for component check Fix hound issues Added Additonal table & relationship Add URL rules & schema additions Fix hound issues Removed redundant relations
mrsaicharan1
added a commit
to mrsaicharan1/open-event-server
that referenced
this pull request
Jul 26, 2019
implemented route for component check Fix hound issues Added Additonal table & relationship Add URL rules & schema additions Fix hound issues Removed redundant relations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6232
Short description of what this resolves:
Checklist
developmentbranch.