fix: add tax information in event copy action #6241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 26, 2019
kushthedude
previously approved these changes
Jul 26, 2019
Codecov Report
@@ Coverage Diff @@
## development #6241 +/- ##
===============================================
+ Coverage 65.69% 65.86% +0.17%
===============================================
Files 286 286
Lines 14529 14494 -35
===============================================
+ Hits 9545 9547 +2
+ Misses 4984 4947 -37
Continue to review full report at Codecov.
|
kushthedude
reviewed
Jul 26, 2019
app/api/event_copy.py
Outdated
| make_transient(tax) | ||
| tax.event_id = event.id | ||
| delattr(tax, 'id') | ||
| save_to_db(tax) |
Member
There was a problem hiding this comment.
Make a function for these 5 lines and reuse
houndci-bot
reviewed
Jul 27, 2019
kushthedude
suggested changes
Jul 27, 2019
| expunge_object(code, event) | ||
|
|
||
| for form in custom_forms: | ||
| form_id = form.id |
Member
There was a problem hiding this comment.
Which is unneeded. I don't see form_id being used anywhere?
app/api/event_copy.py
Outdated
| sponsor_logos_url_task.delay(event_id=event_id) | ||
|
|
||
|
|
||
| def expunge_object(object, event): |
Member
There was a problem hiding this comment.
Suggested change
| def expunge_object(object, event): | |
| def copy_to_event(object, event): |
Member
|
Also, calling save_to_db in for loop is not a good idea. Open an issue to optimize this. So that it only gets called once i.e., Objects are added to session but only committed once |
iamareebjamal
approved these changes
Jul 27, 2019
shreyanshdwivedi
approved these changes
Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6240
Short description of what this resolves:
Add tax information for the events being copied.
Checklist
developmentbranch.