Skip to content

Conversation

@abhinavk96
Copy link
Contributor

Fixes #6250

Short description of what this resolves:

Adds support for fetching discount codes using event identifier, while retaining the functionality of fetching using event id.

@abhinavk96 abhinavk96 changed the title Make discount codes support event_identifiers for fetching them. Make discount codes & access codes support event_identifiers for fetching them. Jul 29, 2019
@iamareebjamal iamareebjamal changed the title Make discount codes & access codes support event_identifiers for fetching them. feat: Make discount codes & access codes support event_identifiers Jul 29, 2019
@fossasia fossasia deleted a comment Jul 29, 2019
@auto-label auto-label bot added the feature label Jul 29, 2019
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #6251 into development will decrease coverage by 0.02%.
The diff coverage is 14.28%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6251      +/-   ##
===============================================
- Coverage        65.86%   65.84%   -0.03%     
===============================================
  Files              286      286              
  Lines            14494    14501       +7     
===============================================
+ Hits              9547     9548       +1     
- Misses            4947     4953       +6
Impacted Files Coverage Δ
app/api/__init__.py 100% <ø> (ø) ⬆️
app/api/discount_codes.py 22.76% <0%> (-0.31%) ⬇️
app/api/access_codes.py 51.8% <25%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d001b...658e634. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 3c747b0 into fossasia:development Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use event identifier instead of event id, in the URLs to fetch discount codes

3 participants