Skip to content

Conversation

@prateekj117
Copy link
Member

Fixes #6272

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jul 31, 2019
@prateekj117
Copy link
Member Author

@iamareebjamal Please review.

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #6274 into development will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #6274      +/-   ##
==============================================
- Coverage        65.69%   65.6%   -0.09%     
==============================================
  Files              286     286              
  Lines            14559   14559              
==============================================
- Hits              9565    9552      -13     
- Misses            4994    5007      +13
Impacted Files Coverage Δ
app/api/custom_forms.py 70.83% <ø> (ø) ⬆️
app/api/feedbacks.py 51.28% <ø> (ø) ⬆️
app/api/custom_system_roles.py 67.74% <ø> (ø) ⬆️
app/api/events.py 22.61% <ø> (ø) ⬆️
app/api/helpers/scheduled_jobs.py 21.42% <0%> (-9.53%) ⬇️
app/api/helpers/query.py 44% <0%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3609c52...23e42ab. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 770d204 into fossasia:development Jul 31, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

before_get_object not called at some places

2 participants