feat: Added function for previous month's ticket sales count #6287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 1, 2019
mrsaicharan1
force-pushed
the
helper-tickets
branch
from
c96e5a2 to
2829e15
Compare
mrsaicharan1
force-pushed
the
helper-tickets
branch
from
2829e15 to
7e8c43c
Compare
Codecov Report
@@ Coverage Diff @@
## development #6287 +/- ##
===============================================
- Coverage 65.26% 65.24% -0.02%
===============================================
Files 287 287
Lines 14713 14719 +6
===============================================
+ Hits 9602 9604 +2
- Misses 5111 5115 +4
Continue to review full report at Codecov.
|
Member
Author
|
@iamareebjamal @uds5501 @shreyanshdwivedi Please have a look |
uds5501
approved these changes
Aug 8, 2019
uds5501
reviewed
Aug 8, 2019
| def calc_tickets_sold_prev_month(self): | ||
| """Calculate tickets sold in the previous month""" | ||
| previous_month = datetime.datetime.now().month - 1 | ||
| return self.tickets_sold.filter_by(completed_at=previous_month).count() |
Contributor
There was a problem hiding this comment.
Shouldn't it be self.tickets_sold_object instead of self.tickets_sold ?
This was referenced Aug 8, 2019
mrsaicharan1
added a commit
to mrsaicharan1/open-event-server
that referenced
this pull request
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6282
Short description of what this resolves:
Implemented function for previous month's ticket sales count. Also refactored object method to reduce code dupl.
Changes proposed in this pull request:
Checklist
developmentbranch.