Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Aug 2, 2019

Fixes #6291

Short description of what this resolves:

Currently, we can find event invoice only via event-invoices/int:id but it should be allowed to be fetched by identifier too - event-invoices/ just like for orders

Changes proposed in this pull request:

  • adds event_invoice_identifier to routes and make proper changes to accommodate it

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Aug 2, 2019
@shreyanshdwivedi shreyanshdwivedi force-pushed the eventInvoice branch 2 times, most recently from 494b985 to 1dd9ab7 Compare August 2, 2019 13:37
@fossasia fossasia deleted a comment Aug 2, 2019
@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal @prateekj117 made the changes. The routes now support both id and identifiers. Please have a look

@fossasia fossasia deleted a comment Aug 3, 2019
@shreyanshdwivedi shreyanshdwivedi changed the title fix: event invoice to be accessed by identifier [WIP] fix: event invoice to be accessed by identifier Aug 3, 2019
@auto-label auto-label bot removed the fix label Aug 3, 2019
@shreyanshdwivedi
Copy link
Member Author

AFK. Will fix travis by tonight

includes event_invoice_id in api routes
@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #6292 into development will decrease coverage by 0.12%.
The diff coverage is 14.28%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6292      +/-   ##
===============================================
- Coverage        65.45%   65.32%   -0.13%     
===============================================
  Files              287      287              
  Lines            14661    14695      +34     
===============================================
+ Hits              9596     9600       +4     
- Misses            5065     5095      +30
Impacted Files Coverage Δ
app/api/users.py 30.23% <0%> (-0.91%) ⬇️
app/api/discount_codes.py 22.27% <0%> (-0.5%) ⬇️
app/api/events.py 21.89% <0%> (-0.27%) ⬇️
app/api/__init__.py 100% <100%> (ø) ⬆️
app/api/helpers/permission_manager.py 28.01% <14.28%> (-0.35%) ⬇️
app/api/event_invoices.py 64.81% <25%> (-11.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3e9a0...99db424. Read the comment docs.

@shreyanshdwivedi shreyanshdwivedi changed the title [WIP] fix: event invoice to be accessed by identifier fix: event invoice to be accessed by identifier Aug 3, 2019
@auto-label auto-label bot added the fix label Aug 3, 2019
@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal fixed travis. Please have a look

@iamareebjamal iamareebjamal merged commit a1fae56 into fossasia:development Aug 3, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event invoices cannot be fetched via identifier

6 participants