-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: event invoice to be accessed by identifier #6292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: event invoice to be accessed by identifier #6292
Conversation
494b985 to
1dd9ab7
Compare
a2db633 to
cd847f0
Compare
|
@iamareebjamal @prateekj117 made the changes. The routes now support both id and identifiers. Please have a look |
62d7c8a to
c54d744
Compare
c54d744 to
29db74f
Compare
|
AFK. Will fix travis by tonight |
includes event_invoice_id in api routes
29db74f to
99db424
Compare
Codecov Report
@@ Coverage Diff @@
## development #6292 +/- ##
===============================================
- Coverage 65.45% 65.32% -0.13%
===============================================
Files 287 287
Lines 14661 14695 +34
===============================================
+ Hits 9596 9600 +4
- Misses 5065 5095 +30
Continue to review full report at Codecov.
|
|
@iamareebjamal fixed travis. Please have a look |
includes event_invoice_id in api routes
Fixes #6291
Short description of what this resolves:
Currently, we can find event invoice only via event-invoices/int:id but it should be allowed to be fetched by identifier too - event-invoices/ just like for orders
Changes proposed in this pull request:
event_invoice_identifierto routes and make proper changes to accommodate itChecklist
developmentbranch.