Skip to content

Conversation

@mrsaicharan1
Copy link
Member

Fixes #6290

Short description of what this resolves:

Changes proposed in this pull request:

  • Added valid choices for schema [event invoices]

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Aug 5, 2019
@mrsaicharan1 mrsaicharan1 changed the title fix: Edit valid choices for invoices fix: Fix valid choices for invoices schema Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #6307 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6307   +/-   ##
============================================
  Coverage        65.29%   65.29%           
============================================
  Files              287      287           
  Lines            14704    14704           
============================================
  Hits              9601     9601           
  Misses            5103     5103
Impacted Files Coverage Δ
app/api/schema/event_invoices.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51065fd...5c80547. Read the comment docs.

kushthedude
kushthedude previously approved these changes Aug 5, 2019
app/api/auth.py Outdated
except NoResultFound:
return UnprocessableEntityError(
{'source': ''}, 'User with id: ' + user_id + ' not found.').respond()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

app/api/auth.py Outdated

return make_response(jsonify(message="Verification email resent"), 200)

@auth_routes.route('/remove-profile-picture/<user_id>', methods=['POST', 'GET'])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

@iamareebjamal iamareebjamal merged commit 5949dc6 into fossasia:development Aug 6, 2019
mrsaicharan1 added a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong event invoice status fields in db schema

5 participants