-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add stripe test key fields to settings model #6322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stripe test key fields to settings model #6322
Conversation
Codecov Report
@@ Coverage Diff @@
## development #6322 +/- ##
===============================================
+ Coverage 65.26% 65.26% +<.01%
===============================================
Files 287 287
Lines 14713 14721 +8
===============================================
+ Hits 9602 9608 +6
- Misses 5111 5113 +2
Continue to review full report at Codecov.
|
06d6499 to
77871ae
Compare
039bc8a to
7563bff
Compare
|
@CosmicCoder96 made the requested changes. Please have a look |
7563bff to
155a880
Compare
9b21caa to
9261708
Compare
adds check to use test keys when app_environment is development
9261708 to
22f4064
Compare
|
@iamareebjamal @mrsaicharan1 @uds5501 please review |
adds check to use test keys when app_environment is development
Fixes #6321
Short description of what this resolves:
Currently, there are only stripe client ID, secret key and publishable key in settings model, there should be test keys fields and they should be used when Debug is true
Changes proposed in this pull request:
Checklist
developmentbranch.