Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

Fixes #6321

Short description of what this resolves:

Currently, there are only stripe client ID, secret key and publishable key in settings model, there should be test keys fields and they should be used when Debug is true

Changes proposed in this pull request:

  • adds stripe test keys to settings model
  • need to add a check to use these keys is debug is true

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #6322 into development will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6322      +/-   ##
===============================================
+ Coverage        65.26%   65.26%   +<.01%     
===============================================
  Files              287      287              
  Lines            14713    14721       +8     
===============================================
+ Hits              9602     9608       +6     
- Misses            5111     5113       +2
Impacted Files Coverage Δ
app/api/helpers/payment.py 27.52% <0%> (-0.52%) ⬇️
app/models/setting.py 90.86% <100%> (+0.2%) ⬆️
app/api/schema/settings.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e390b56...22f4064. Read the comment docs.

@shreyanshdwivedi shreyanshdwivedi changed the title [WIP] enh: add stripe test key fields to settings model enh: add stripe test key fields to settings model Aug 6, 2019
@shreyanshdwivedi shreyanshdwivedi force-pushed the stripeTest branch 3 times, most recently from 039bc8a to 7563bff Compare August 6, 2019 19:51
@shreyanshdwivedi
Copy link
Member Author

@CosmicCoder96 made the requested changes. Please have a look

@shreyanshdwivedi shreyanshdwivedi force-pushed the stripeTest branch 2 times, most recently from 9b21caa to 9261708 Compare August 7, 2019 09:07
@fossasia fossasia deleted a comment Aug 7, 2019
adds check to use test keys when app_environment is development
@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal @mrsaicharan1 @uds5501 please review

@iamareebjamal iamareebjamal changed the title enh: add stripe test key fields to settings model feat: add stripe test key fields to settings model Aug 7, 2019
@auto-label auto-label bot added the feature label Aug 7, 2019
@iamareebjamal iamareebjamal merged commit 1d777ae into fossasia:development Aug 8, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the stripeTest branch August 8, 2019 08:25
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Aug 9, 2019
adds check to use test keys when app_environment is development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add stripe test key fields in DB

5 participants