Skip to content

fix: Typo in the notification invitation message #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2019
Merged

fix: Typo in the notification invitation message #6346

merged 3 commits into from
Aug 13, 2019

Conversation

@smcri
Copy link
Contributor

@smcri smcri commented Aug 11, 2019

Fixes #5872

Short description of what this resolves:

Resolves display of 'a' in event notifications

Changes proposed in this pull request:

Changes notification message such that event role beginning with vowel or consonant does not matter

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

shreyanshdwivedi
shreyanshdwivedi reviewed Aug 12, 2019
View reviewed changes
app/api/helpers/system_notifications.py Outdated
EVENT_ROLE: {
'title': u'Invitation to be {role_name} at {event_name}',
'message': u"You've been invited to be a <strong>{role_name}</strong>" +
'message': u"You've been invited to be one of the <strong>{role_name}</strong>s" +
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just replace a with an as mentioned in the issue

Copy link
Member

@kushthedude kushthedude Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyanshdwivedi It will require a condition block too then, Its a nice makeover done by him 😄

Copy link
Member

@shreyanshdwivedi shreyanshdwivedi Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the s must be in strong block itself

mrsaicharan1
mrsaicharan1 suggested changes Aug 12, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smcri Please move the 's' literal inside the strong block and use semantic naming conventions for the PR. (https://probot.github.io/apps/semantic-pull-requests/)

@codecov
Copy link

codecov bot commented Aug 12, 2019 •
edited
Loading

Codecov Report

Merging #6346 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6346   +/-   ##
============================================
  Coverage        65.38%   65.38%           
============================================
  Files              287      287           
  Lines            14725    14725           
============================================
  Hits              9628     9628           
  Misses            5097     5097
Impacted Files Coverage Δ
app/api/helpers/system_notifications.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e6a77...ce7e2f0. Read the comment docs.

@smcri
Copy link
Contributor Author

smcri commented Aug 12, 2019

Moved s literal inside strong block.

@smcri smcri changed the title Fixed Typo fix : Typo in the notification invitation message Aug 12, 2019
@iamareebjamal iamareebjamal changed the title fix : Typo in the notification invitation message fix: Typo in the notification invitation message Aug 12, 2019
@auto-label auto-label bot added the fix label Aug 12, 2019
mrsaicharan1
mrsaicharan1 approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smcri
Copy link
Contributor Author

smcri commented Aug 13, 2019

Unable to merge into fossasia: development.

@mrsaicharan1
Copy link
Member

mrsaicharan1 commented Aug 13, 2019 via email

@iamareebjamal iamareebjamal merged commit 1dca10e into fossasia:development Aug 13, 2019
@smcri smcri deleted the 5872 branch August 13, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+4 more reviewers

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

@shreyanshdwivedi shreyanshdwivedi shreyanshdwivedi approved these changes

@prateekj117 prateekj117 prateekj117 approved these changes

@kushthedude kushthedude kushthedude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in the notification invitation message

6 participants

@smcri @mrsaicharan1 @iamareebjamal @shreyanshdwivedi @prateekj117 @kushthedude