-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: remove pending from default invoice status #6369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Shouldn't you also write a migration for existing ones with pending status? And also for new ones with default status |
|
I think currently the event invoice not completely in function so maybe they are not in db too |
ca751bf
|
@iamareebjamal I have included the migration, please review now |
Codecov Report
@@ Coverage Diff @@
## development #6369 +/- ##
============================================
Coverage 65.29% 65.29%
============================================
Files 287 287
Lines 14775 14775
============================================
Hits 9647 9647
Misses 5128 5128
Continue to review full report at Codecov.
|
mrsaicharan1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this migration would do. Did you test it out by running it locally though?
|
@mrsaicharan1 yes, tested it locally, it's working |
Fixes #6368
Changes proposed in this pull request:
Checklist
developmentbranch.