fix: Delete duplicate ticket tags

[prateekj117]

Fixes #6382

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream development branch.
• The unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

• All the functions created/modified in this PR contain relevant docstrings.

[iamareebjamal]

Do you think after the previous migration has failed due to duplicate ticket tags, this will even get executed?

And do you think setting deleted_at will do anything to prevent the unique constraint fot ticket tags?

You are again sending the PR without reproducing the bug and even verifying that it works. Flailing your arms in a dark room blindfolded will not solve this bug

[prateekj117]

@iamareebjamal I changed the revision and downrevision appropriately. And I am also appending '.deleted' to the ticket-tag.

It works locally. I check running the migrations. Though as one more migration has merged for event_invoice, I have to make those changes.

[codecov]

Codecov Report

Merging #6386 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #6386   +/-   ##
============================================
  Coverage        65.16%   65.16%           
============================================
  Files              287      287           
  Lines            14810    14810           
============================================
  Hits              9651     9651           
  Misses            5159     5159

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead0ba0...f244528. Read the comment docs.

[prateekj117]

@iamareebjamal Done.

[iamareebjamal]

This will work, but what about tickets linked with the deleted ticket tag?

[prateekj117]

@iamareebjamal I couldn't find where it's saving the information about the ticket linked with the ticket-tag.

[iamareebjamal]

Ran your migration. There are still duplicates and the proceeding migration failed. What did you even test?

@CosmicCoder96 Are ticket tags even being used, there is no entry in association table?

[prateekj117]

@iamareebjamal I tested it using in and not not in because I had the unique constraint already.
Sorry for the Negligence.
Weirdly enough, it turns out not in is returning no entries even in case of duplicates.

[iamareebjamal]

Then it is wrong query

[prateekj117]

@iamareebjamal I have corrected the query. Please review.

[iamareebjamal]

Doesn't work if there are more than 2 duplicates

[abhinavk96]

@CosmicCoder96 Are ticket tags even being used, there is no entry in association table?

@iamareebjamal I don't think they are consumed by current FE, but they are anyway supported by the ticketing API, referred to multiple times in it. And the only ticket tags I see are for some events on legacy data.
Association table is empty even inside legacy database.

[iamareebjamal]

@prateekj117 Wrap this up ASAP, please

[prateekj117]

@iamareebjamal It's working even when there are more than two duplicates:

[iamareebjamal]

Yeah, so exactly @prateekj117

Do you think the unique constraint will work on the data above?

[iamareebjamal]

(15, paid !!!!.deleted) is still duplicated. So how it is going to work?

[prateekj117]

@iamareebjamal Ok, I got the point.

[prateekj117]

@iamareebjamal Should I delete the rows?

[iamareebjamal]

No

[prateekj117]

@iamareebjamal Can you give me a rough idea on how to go about for a query like that?

[iamareebjamal]

Append id or fixed random characters before .deleted

And change the implementation of downgrade accordingly

[prateekj117]

@iamareebjamal Done.

[iamareebjamal]

@CosmicCoder96 Please verify

[abhinavk96]

Tested on production data locally, worked.