Skip to content

Conversation

@anhanh11001
Copy link
Contributor

@anhanh11001 anhanh11001 commented Aug 21, 2019

@auto-label auto-label bot added the fix label Aug 21, 2019
@anhanh11001
Copy link
Contributor Author

@iamareebjamal please review

@iamareebjamal iamareebjamal changed the title fix: Configure PayPal fix: Configure PayPal for mobile payments Aug 21, 2019
@iamareebjamal
Copy link
Member

Have you tested it to be working with settings?

@anhanh11001
Copy link
Contributor Author

anhanh11001 commented Aug 21, 2019

I haven't cause I still don't know where to put the client ID and secret. I just follow the implementation from the function above. Where should I put it?

@iamareebjamal
Copy link
Member

See settings API

@anhanh11001
Copy link
Contributor Author

Sorry for the long response but I'm having a problem reinstalling my environment (pycrypto). I'll try to see if I can get my env installed again and hopefully can have it tested today. Here is something I read on Github, maybe it would be helpful in the future: pycrypto/pycrypto#238

@iamareebjamal
Copy link
Member

You can use deps-pycryptodome branch

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #6406 into development will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #6406      +/-   ##
==============================================
- Coverage         64.9%   64.9%   -0.01%     
==============================================
  Files              288     288              
  Lines            14911   14912       +1     
==============================================
  Hits              9678    9678              
- Misses            5233    5234       +1
Impacted Files Coverage Δ
app/api/helpers/payment.py 25% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622ae4f...16ce0b0. Read the comment docs.

@anhanh11001
Copy link
Contributor Author

Got that working for me

@iamareebjamal iamareebjamal merged commit 8a141af into fossasia:development Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PayPal not configured for verify payment method

2 participants