Skip to content

Conversation

@abhinavk96
Copy link
Contributor

Fixes #6407

Short description of what this resolves:

Changes proposed in this pull request:

@abhinavk96 abhinavk96 force-pushed the alpha branch 2 times, most recently from 8ae6d54 to fc9915b Compare August 22, 2019 03:05
@abhinavk96
Copy link
Contributor Author

To be reviewed, after I test the functionality while developing client side logic on FE in parallel, to be in WIP until then.
Migration file missing intentionally, still working on some fields.

@abhinavk96 abhinavk96 force-pushed the alpha branch 2 times, most recently from ae8a73e to 5e2364b Compare August 23, 2019 16:29
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #6408 into development will increase coverage by 0.07%.
The diff coverage is 85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6408      +/-   ##
===============================================
+ Coverage        64.41%   64.49%   +0.07%     
===============================================
  Files              288      291       +3     
  Lines            15058    15117      +59     
===============================================
+ Hits              9699     9749      +50     
- Misses            5359     5368       +9
Impacted Files Coverage Δ
app/api/schema/custom_form_options.py 100% <100%> (ø)
app/api/schema/custom_forms.py 100% <100%> (ø) ⬆️
app/models/custom_form.py 92.68% <100%> (+1.01%) ⬆️
app/api/__init__.py 100% <100%> (ø) ⬆️
app/models/custom_form_option.py 66.66% <66.66%> (ø)
app/api/custom_form_options.py 77.77% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fd647...ef65940. Read the comment docs.

@abhinavk96 abhinavk96 force-pushed the alpha branch 2 times, most recently from a9f1a96 to 87e4c62 Compare August 25, 2019 00:42
@fossasia fossasia deleted a comment Aug 25, 2019
@fossasia fossasia deleted a comment Aug 25, 2019
@fossasia fossasia deleted a comment Aug 25, 2019
@fossasia fossasia deleted a comment Sep 1, 2019
@fossasia fossasia deleted a comment Sep 1, 2019
@fossasia fossasia deleted a comment Sep 1, 2019
@abhinavk96 abhinavk96 changed the title [WIP] feat: create custom_form_options api feat: create custom_form_options api Sep 1, 2019
@abhinavk96
Copy link
Contributor Author

abhinavk96 commented Sep 1, 2019

@iamareebjamal made the requested changes.

@fossasia fossasia deleted a comment Sep 1, 2019
@abhinavk96 abhinavk96 merged commit 5e0e515 into fossasia:development Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement schema and APIs to support complex custom forms

4 participants