Skip to content

Conversation

@anhanh11001
Copy link
Contributor

Fixes #6411

@auto-label auto-label bot added the fix label Aug 23, 2019
@iamareebjamal
Copy link
Member

Why did you say it worked when it didn't?

@iamareebjamal iamareebjamal changed the title fix: Wrong comparation type fix: Comparison cast for paypal payment verification Aug 23, 2019
@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #6412 into development will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #6412      +/-   ##
==============================================
- Coverage        64.92%   64.9%   -0.03%     
==============================================
  Files              288     288              
  Lines            14912   14912              
==============================================
- Hits              9681    9678       -3     
- Misses            5231    5234       +3
Impacted Files Coverage Δ
app/api/helpers/payment.py 25% <0%> (ø) ⬆️
app/api/helpers/scheduled_jobs.py 20.93% <0%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a141af...6610469. Read the comment docs.

@anhanh11001
Copy link
Contributor Author

anhanh11001 commented Aug 23, 2019

About the mistake above, I forgot to put change.

Also, I think I should also tell you this: sorry for not testing properly as I couldn't set up my local database so I just create an object manually and test if it matches my postman request, it wasn't proper testing. I should have asked for proper guideline instead of doing this.

@iamareebjamal iamareebjamal merged commit a408e39 into fossasia:development Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong type to compare when verifying PayPal order

2 participants