chore: Make docker-compose production ready #6415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use images instead of build - Simplify docker-compose-dev.yml - Remove ElasticSearch container - Add logic for waiting for database
Member
Author
|
@CosmicCoder96 Please test |
Codecov Report
@@ Coverage Diff @@
## development #6415 +/- ##
===============================================
- Coverage 64.77% 64.74% -0.03%
===============================================
Files 288 288
Lines 14966 14966
===============================================
- Hits 9694 9690 -4
- Misses 5272 5276 +4
Continue to review full report at Codecov.
|
abhinavk96
reviewed
Aug 26, 2019
|
|
||
| x-defaults: &defaults | ||
| build: . | ||
| image: eventyay/open-event-server |
Member
Author
There was a problem hiding this comment.
Automatically defaults to latest. Making new changes unnecessary and easier to update
abhinavk96
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5893