Skip to content

Conversation

@anhanh11001
Copy link
Contributor

Fixes: #6416

@auto-label auto-label bot added the fix label Aug 25, 2019
@anhanh11001 anhanh11001 changed the title fix: Add save_to_db fix: Add save_to_db in payment.py Aug 25, 2019
@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #6417 into development will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6417      +/-   ##
===============================================
- Coverage        64.77%   64.74%   -0.03%     
===============================================
  Files              288      288              
  Lines            14966    14966              
===============================================
- Hits              9694     9690       -4     
- Misses            5272     5276       +4
Impacted Files Coverage Δ
app/api/helpers/payment.py 24.84% <100%> (ø) ⬆️
app/api/helpers/scheduled_jobs.py 20.93% <0%> (-3.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d0b57...1feca9a. Read the comment docs.

@prateekj117
Copy link
Member

@anhanh11001 get_settings is imported twice in this file. Correct it here only.

@liveHarshit
Copy link
Member

@anhanh11001 Any updates?

@iamareebjamal iamareebjamal merged commit 003bf08 into fossasia:development Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

save_to_db function is mistakenly removed in helpers/payment.py

4 participants