Skip to content

Conversation

@abhinavk96
Copy link
Contributor

@abhinavk96 abhinavk96 commented Aug 29, 2019

Fixes #6213
Fixes #6409
Fixes #6214
Fixes #6392

Short description of what this resolves:

Removes the unnecessary replacement in returned URL of the storage helper.

@iamareebjamal This might just fix the images on localhost issue too, as previously static domain wasn't configured now it is.

@auto-label auto-label bot added the fix label Aug 29, 2019
@abhinavk96
Copy link
Contributor Author

abhinavk96 commented Aug 29, 2019

Tested in deployed environment, worked.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #6425 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #6425   +/-   ##
============================================
  Coverage        64.74%   64.74%           
============================================
  Files              288      288           
  Lines            14966    14966           
============================================
  Hits              9690     9690           
  Misses            5276     5276
Impacted Files Coverage Δ
app/api/helpers/storage.py 59.29% <ø> (ø) ⬆️
tests/all/integration/api/helpers/test_storage.py 90.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 003bf08...cd00e3c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants